Merge pull request #20 from unrvld/feature/fix-prefix-parsing

Fix resolving of endpoint
unrvld · Jun 9, 2024 · 882edb0 · 882edb0
2 parents de226da + 7470e13
commit 882edb0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/.github/workflows/build-visitor-groups.yml b/.github/workflows/build-visitor-groups.yml
@@ -8,8 +8,8 @@ on:
   workflow_dispatch:
 
 env:
-  BUILD_NO: 2.0.0.${{ github.run_number }}  
-  BUILD_NO_PRE: 2.0.0-rc.${{ github.run_number }} 
+  BUILD_NO: 2.0.1.${{ github.run_number }}  
+  BUILD_NO_PRE: 2.0.1-rc.${{ github.run_number }} 
 
 jobs:
   build:

diff --git a/src/UNRVLD.ODP.VisitorGroups/Criteria/StandardPrefixer.cs b/src/UNRVLD.ODP.VisitorGroups/Criteria/StandardPrefixer.cs
@@ -5,12 +5,7 @@ namespace UNRVLD.ODP.VisitorGroups.Criteria
 {
     public class StandardPrefixer : IPrefixer
     {
-        private readonly Regex prefixRegex;
-
-        public StandardPrefixer()
-        {
-            prefixRegex = new Regex(@"^\[(.+)\] - (.+)$", RegexOptions.Compiled);
-        }
+        private static readonly Regex PrefixRegex = new(@"^\[(.+)\] - (.+)$", RegexOptions.Compiled);
 
         public string Prefix(string value, string prefix)
         {
@@ -19,9 +14,9 @@ public string Prefix(string value, string prefix)
 
         public (string? prefix, string value) SplitPrefix(string value)
         {
-            var match = prefixRegex.Match(value);
+            var match = PrefixRegex.Match(value);
 
-            return match.Success ? (match.Groups[1].Value, match.Groups[2].Value) : (string.Empty, value);
+            return match.Success ? (match.Groups[1].Value, match.Groups[2].Value) : (null, value);
         }
     }
 }
diff --git a/src/UNRVLD.ODP.VisitorGroups/UNRVLD.ODP.VisitorGroups.csproj b/src/UNRVLD.ODP.VisitorGroups/UNRVLD.ODP.VisitorGroups.csproj
@@ -4,7 +4,7 @@
 		<TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
 		<PackageId>UNRVLD.ODP.VisitorGroups</PackageId>
 		<RepositoryUrl>https://github.com/made-to-engage/ODP.VisitorGroups</RepositoryUrl>
-		<Version>2.0.0</Version>
+		<Version>2.0.1</Version>
 		<Authors>Andrew Markham; David Knipe</Authors>
 		<Owners>Made to Engage;UNRVLD</Owners>
 		<Title>UNRVLD - Optimizely Visitor Groups</Title>