Skip to content

Add OCI image manifest support in DockerClient - #2725

Open
Mainfrezzer wants to merge 1 commit into
unraid:masterfrom
Mainfrezzer:Mainfrezzer-patch-4
Open

Add OCI image manifest support in DockerClient#2725
Mainfrezzer wants to merge 1 commit into
unraid:masterfrom
Mainfrezzer:Mainfrezzer-patch-4

Conversation

@Mainfrezzer

@Mainfrezzer Mainfrezzer commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Github is being Github. Manifests wont be pulled without it for newer pushes

Summary by CodeRabbit

  • Bug Fixes
    • Improved Docker Registry compatibility by supporting OCI image manifests and image indexes when retrieving image metadata.

Github is being Github. Manifests wont be pulled without it for newer pushes
@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ba101aca-7f69-406d-b497-2241d4575bb1

📥 Commits

Reviewing files that changed from the base of the PR and between 4b3c59e and 7ca5d3b.

📒 Files selected for processing (1)
  • emhttp/plugins/dynamix.docker.manager/include/DockerClient.php

Walkthrough

The Docker client now includes OCI image manifest and image index media types in the Docker Registry v2 manifest request Accept header.

Changes

Docker manifest support

Layer / File(s) Summary
Manifest Accept header
emhttp/plugins/dynamix.docker.manager/include/DockerClient.php
The manifest request accepts Docker Registry v2 and OCI image manifest media types, including OCI image indexes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7ca5d

This is a small, localized manifest-handling change, and no actionable merge-blocking risk remains beyond normal checks and review.

Poem

A rabbit checks the registry door,
OCI banners join the score.
Manifests hop through headers bright,
Indexes join the pull tonight.
Code stays small, and paths grow right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the addition of OCI image manifest support in DockerClient.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.08.15.0942
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2725/webgui-pr-2725.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix.docker.manager/include/DockerClient.php

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2725, or run:

plugin remove webgui-pr-2725

🤖 This comment is automatically generated and will be updated with each new push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant