Skip to content

fix(docker): clear the update-available flag after an out-of-band image update #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Junker der Provinz (junkerderprovinz) wants to merge 2 commits into
base: master
Choose a base branch
from
+20 −11
Open

fix(docker): clear the update-available flag after an out-of-band image update #2723

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b60d0b
fix(docker): clear the update-available flag after an out-of-band ima…
junkerderprovinz Aug 13, 2026
7d057cd
Merge branch 'master' into fix/docker-stale-update-status
junkerderprovinz Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions emhttp/plugins/dynamix.docker.manager/include/DockerClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,31 +615,40 @@ public function reloadUpdateStatus($image=null) {
$updateStatus = DockerUtil::loadJSON($dockerManPaths['update-status']);
$images = $image ? [DockerUtil::ensureImageTag($image)] : array_map(function($ar){return $ar['Tags'][0]??'';}, $DockerClient->getDockerImages());
foreach ($images as $img) {
$localVersion = null;
if (!empty($updateStatus[$img]) && array_key_exists('local', $updateStatus[$img])) {
$remoteVersion = $this->getRemoteVersionV2($img);
// always re-inspect the local image: its digest changes whenever the image is replaced
// outside the docker manager (docker pull/recreate via CLI or API), and a cached digest
// would keep reporting a stale update status forever
$localVersion = $this->inspectLocalVersion($img, $remoteVersion);
if ($localVersion === null && !empty($updateStatus[$img]) && array_key_exists('local', $updateStatus[$img])) {
// image has no repo digest (e.g. built locally), keep the last known value
$localVersion = $updateStatus[$img]['local'];
}
if ($localVersion === null) {
$localVersion = $this->inspectLocalVersion($img);
}
$remoteVersion = $this->getRemoteVersionV2($img);
$status = ($localVersion && $remoteVersion) ? (($remoteVersion == $localVersion) ? 'true' : 'false') : 'undef';
$updateStatus[$img] = ['local' => $localVersion, 'remote' => $remoteVersion, 'status' => $status];
//$this->debug("Update status: Image='$img', Local='$localVersion', Remote='$remoteVersion', Status='$status'");
}
DockerUtil::saveJSON($dockerManPaths['update-status'], $updateStatus);
}

public function inspectLocalVersion($image) {
public function inspectLocalVersion($image, $remote=null) {
$DockerClient = new DockerClient();
$inspect = $DockerClient->getDockerJSON('/images/'.$image.'/json');
if (empty($inspect['RepoDigests'])) return null;

$repoDigest = $inspect['RepoDigests'][array_key_last($inspect['RepoDigests'])];
$shaPos = strpos($repoDigest, '@sha256:');
if ($shaPos === false) return null;
$digests = [];
foreach ($inspect['RepoDigests'] as $repoDigest) {
$shaPos = strpos($repoDigest, '@sha256:');
if ($shaPos !== false) $digests[] = substr($repoDigest, $shaPos + 1);
}
if (!$digests) return null;

// one image can carry several digests for the same repo (a multiarch tag that got re-pushed
// keeps the older manifest list too), and the tag does not always point at the newest entry.
// If the digest the tag currently resolves to is among them, this image is that tag.
if ($remote !== null && in_array($remote, $digests, true)) return $remote;

return substr($repoDigest, $shaPos + 1);
return end($digests);
}

public function setUpdateStatus($image, $version) {
Expand Down