test: add integration tests for deleting invalid notifications

[pujitm]

Summary by CodeRabbit

• Tests

  • Added integration tests for notification deletion, validating behavior with on-disk files and ensuring proper cleanup of invalid notifications.
  • Improved test setup and isolation using a temporary notifications directory for reliable filesystem interactions.
  • Expanded coverage of notification overview updates and levels (e.g., unread/archive, severity), increasing confidence in real-world scenarios.

• Chores

  • Strengthened test scaffolding to improve stability and reliability of the notifications feature.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Adds filesystem-backed integration tests to loadNotificationsFile.test.ts, introducing temporary directory setup, module mocks for store/pubsub/logger, and a new test suite exercising NotificationsService.deleteNotification against on-disk files, including cleanup and assertions on deletion results and overview publishing.

Changes

Cohort / File(s)	Summary
Tests: NotificationsService integration and scaffolding api/src/unraid-api/graph/resolvers/notifications/loadNotificationsFile.test.ts	Expanded test to use tmp FS for notifications; added mocks for @app/store, @app/core/pubsub, and @nestjs/common Logger; created integration test for deleteNotification handling an invalid on-disk file; added setup/teardown using fs utilities.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• feat: recreate watcher on path change #1203 — Adjusts notification path handling and watcher recreation; related to this PR’s tests that mock and rely on dynamix.notify.path.
• fix(notifications): gracefully handle & mask invalid notifications #1529 — Modifies invalid notification file handling in loader; this PR’s tests create invalid files and validate behavior against deletion and overview.

Suggested reviewers

• mdatelle
• elibosley

Poem

In a temp dir burrow, I write and I sweep,
Little files vanish—no need to weep.
Mocked winds whisper: “Publish the news!”
Logger nods softly, with silent cues.
I twitch my nose—tests hop and pass,
Carrots for coverage, green as grass. 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c508366 and cbebc73.

📒 Files selected for processing (1)

• api/src/unraid-api/graph/resolvers/notifications/loadNotificationsFile.test.ts (4 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/del-invalid-notif

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[claude]

Claude finished @pujitm's task —— View job

---

Code Review Complete

Reviewing the changes in this PR focusing on critical issues in the diff only.

Todo List:

• Read the changed test file to understand the modifications
• Analyze only the added/modified lines for critical issues
• Provide review feedback

Review Findings

✅ No critical issues found in changes

The diff adds integration tests for deleting invalid notifications. Key changes analyzed:

Lines 3-5, 7: Added filesystem imports (fs, os, path) and afterEach from vitest - standard testing utilities
Lines 17-33: Modified mock to use temporary directory path instead of hardcoded /test/notifications - improvement for test isolation
Lines 35-43: Added pubsub mock - proper mocking of dependencies
Lines 59-60: Added test directory variable - consistent with mock setup
Lines 252-312: New integration test suite for deleteNotification

The new integration test properly:

• Sets up/tears down temporary test directories (lines 256-274)
• Creates actual invalid notification files on disk (lines 278-286)
• Verifies file deletion behavior (lines 288-297)
• Tests both success conditions and proper cleanup

No security, logic, or breaking change issues detected in the added code.

[github-actions]

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1626/dynamix.unraid.net.plg