feat: add tailwind class sort plugin #1562

mdatelle · 2025-08-04T15:13:28Z

Summary by CodeRabbit

Chores
- Updated code formatting tools to include support for Tailwind CSS-specific formatting.
- Adjusted code formatting issue reporting from errors to warnings for a smoother development experience.

coderabbitai · 2025-08-04T15:13:36Z

Walkthrough

The Prettier configuration in both the web and unraid-ui projects was updated to include the prettier-plugin-tailwindcss plugin. Correspondingly, this plugin was added as a development dependency in both projects' package.json files. Additionally, the ESLint configuration in unraid-ui was modified to downgrade the severity of the prettier/prettier rule from error to warning. No other configuration or dependency changes were made.

Changes

Cohort / File(s)	Change Summary
Prettier Configuration Updates `web/.prettierrc.mjs`, `unraid-ui/.prettierrc.json`	Added `prettier-plugin-tailwindcss` alongside existing plugins to enable Tailwind CSS-specific formatting.
Dev Dependency Additions `web/package.json`, `unraid-ui/package.json`	Added `prettier-plugin-tailwindcss` (version ^0.6.14) to devDependencies in both projects.
ESLint Configuration Update `unraid-ui/eslint.config.ts`	Changed `prettier/prettier` rule severity from `"error"` to `"warn"` to reduce strictness of formatting errors.

Sequence Diagram(s)

Not included: The changes are limited to configuration and dependency updates without affecting control flow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

chore(web): add prettier config + tailwind class sorting #955: Both PRs modify the Prettier configuration to include the prettier-plugin-tailwindcss plugin for Tailwind CSS class sorting, directly relating their changes in the web/.prettierrc.mjs and web/package.json files.
chore: add import organizer to prettier config #959: Related by purpose; this PR adds the Tailwind CSS plugin while the other added the import sorting plugin and import order settings to Prettier config.

Suggested reviewers

elibosley
zackspear

Poem

A rabbit hopped through fields of code,
With Prettier plugins in its load.
Tailwind classes now align,
In order neat, they intertwine.
Formatting bliss, a gentle breeze—
Review this change with utmost ease! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9e7c6a6 and 4ea74e1.

📒 Files selected for processing (1)

unraid-ui/eslint.config.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

unraid-ui/eslint.config.ts

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/add-tailwind-class-sort-plugin

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

claude · 2025-08-04T15:13:43Z

Claude finished @mdatelle's task —— View job

Code Review: Tailwind Class Sort Plugin

Todo List

Analyze changed files and implementation approach
Review plugin configuration and compatibility
Check for potential issues and best practices
Provide comprehensive feedback

Critical Issue Analysis

Reviewing only the changed lines in this PR:

Changed Lines Analysis:

web/package.json:76 - Added "prettier-plugin-tailwindcss": "^0.6.14"
web/.prettierrc.mjs:10 - Added 'prettier-plugin-tailwindcss' to plugins array
unraid-ui/package.json:101 - Added "prettier-plugin-tailwindcss": "^0.6.14"
unraid-ui/.prettierrc.json:6 - Added "prettier-plugin-tailwindcss" to plugins array
unraid-ui/eslint.config.ts:22 - Changed 'prettier/prettier': 'error' to 'prettier/prettier': 'warn'

✅ No critical issues found in changes

The modifications are purely additive configuration changes for code formatting tools. No logic errors, security vulnerabilities, breaking changes, or data loss risks identified in the diff.

claude · 2025-08-04T15:54:55Z

Claude finished @mdatelle's task —— View job

Code Review: Tailwind Class Sort Plugin

Todo List

Analyze changed files and implementation approach
Review plugin configuration and compatibility
Check for potential issues and best practices
Assess security and performance considerations
Provide comprehensive feedback

✅ Code Quality & Best Practices

Excellent implementation! This PR correctly adds prettier-plugin-tailwindcss v0.6.14 and integrates it properly with the existing Prettier configuration.

Strengths:

Proper plugin ordering: The plugin is correctly placed after the import sorter in the plugins array (web/.prettierrc.mjs:10)
Version choice: Uses a stable, recent version (v0.6.14) that's compatible with Tailwind v4
Clean integration: Minimal, focused changes that don't disrupt existing formatting rules
Consistent with project structure: Added only to the web package where Tailwind is actively used

🔧 Technical Analysis

Plugin Compatibility:

✅ Compatible with existing @ianvs/prettier-plugin-sort-imports
✅ Works correctly with Tailwind v4 (confirmed project is using @tailwindcss/vite v4.1.11)
✅ Plugin ordering ensures imports are sorted first, then Tailwind classes

Configuration Review:

The Prettier config in web/.prettierrc.mjs is well-structured with clear import ordering rules
Plugin placement at the end of the plugins array follows recommended practices
No additional configuration needed - the plugin works with sensible defaults

🚀 Performance Considerations

Positive impacts:

Faster development: Automatic class sorting reduces manual formatting time
Consistent output: Eliminates class order variations between developers
Build optimization: Properly ordered classes may compress slightly better

Minimal overhead:

Plugin only runs during formatting (not in runtime)
Version 0.6.14 has performance improvements over earlier versions

🔒 Security Assessment

No security concerns identified:

Plugin is a well-maintained, official Tailwind Labs tool
Added to devDependencies only (not shipped to production)
No network requests or external API calls
Source code is open and auditable

🧪 Test Coverage Considerations

Current state:

No tests needed for this formatting-only change
Plugin behavior is deterministic and well-tested upstream
Existing tests will continue to pass (formatting changes won't break functionality)

Recommendations:

Consider running pnpm lint:fix on existing files to apply consistent formatting
May want to run formatting on a few test files to verify expected behavior

📊 File-by-File Analysis

web/package.json:76:

"prettier-plugin-tailwindcss": "^0.6.14"

✅ Appropriate caret range for minor/patch updates
✅ Added to devDependencies (correct scope)

web/.prettierrc.mjs:10:

plugins: ['@ianvs/prettier-plugin-sort-imports', 'prettier-plugin-tailwindcss']

✅ Correct plugin order (import sorting before class sorting)
✅ Maintains existing import organization rules

unraid-ui/.prettierrc.json:6:

"plugins": ["@ianvs/prettier-plugin-sort-imports", "prettier-plugin-tailwindcss"]

✅ Consistent configuration across packages
✅ Same proper plugin ordering

unraid-ui/package.json:99:

"prettier-plugin-tailwindcss": "^0.6.14"

✅ Version consistency across packages
✅ Proper dependency scope

pnpm-lock.yaml:

✅ Standard lockfile updates with proper dependency resolution

🎯 Recommendations

Immediate actions:
- ✅ Ready to merge as-is
- Consider running pnpm --filter ./web lint:fix and pnpm --filter ./unraid-ui lint:fix to format existing files
Optional enhancements:
- Could add a note in project docs about automatic Tailwind class sorting
- Consider adding to the root .prettierrc if other packages start using Tailwind
Future considerations:
- Monitor for new plugin versions with additional Tailwind v4 optimizations

🏆 Summary

This is a high-quality, low-risk change that will improve developer experience and code consistency. The implementation follows all best practices and integrates seamlessly with the existing toolchain.

Verdict: ✅ Approved - Ready for merge

github-actions · 2025-08-04T15:56:37Z

🚀 Storybook has been deployed to staging: https://unraid-ui-storybook-staging.unraid-workers.workers.dev

claude · 2025-08-04T17:13:13Z

Claude finished @mdatelle's task —— View job

Code Review: Tailwind Class Sort Plugin

Todo List

Analyze changed files and implementation approach
Review plugin configuration and compatibility
Check for potential issues and best practices
Assess security and performance considerations
Provide comprehensive feedback

✅ Code Quality & Best Practices

Excellent implementation! This PR correctly adds prettier-plugin-tailwindcss v0.6.14 and integrates it properly with the existing Prettier configuration.

Strengths:

Proper plugin ordering: The plugin is correctly placed after the import sorter in the plugins array (web/.prettierrc.mjs:10)
Version choice: Uses a stable, recent version (v0.6.14) that's compatible with Tailwind v4
Clean integration: Minimal, focused changes that don't disrupt existing formatting rules
Consistent with project structure: Added only to the web package where Tailwind is actively used

🔧 Technical Analysis

Plugin Compatibility:

✅ Compatible with existing @ianvs/prettier-plugin-sort-imports
✅ Works correctly with Tailwind v4 (confirmed project is using @tailwindcss/vite v4.1.11)
✅ Plugin ordering ensures imports are sorted first, then Tailwind classes

Configuration Review:

The Prettier config in web/.prettierrc.mjs is well-structured with clear import ordering rules
Plugin placement at the end of the plugins array follows recommended practices
No additional configuration needed - the plugin works with sensible defaults

🚀 Performance Considerations

Positive impacts:

Faster development: Automatic class sorting reduces manual formatting time
Consistent output: Eliminates class order variations between developers
Build optimization: Properly ordered classes may compress slightly better

Minimal overhead:

Plugin only runs during formatting (not in runtime)
Version 0.6.14 has performance improvements over earlier versions

🔒 Security Assessment

No security concerns identified:

Plugin is a well-maintained, official Tailwind Labs tool
Added to devDependencies only (not shipped to production)
No network requests or external API calls
Source code is open and auditable

🧪 Test Coverage Considerations

Current state:

No tests needed for this formatting-only change
Plugin behavior is deterministic and well-tested upstream
Existing tests will continue to pass (formatting changes won't break functionality)

Recommendations:

Consider running pnpm lint:fix on existing files to apply consistent formatting
May want to run formatting on a few test files to verify expected behavior

📊 File-by-File Analysis

web/package.json:76:

"prettier-plugin-tailwindcss": "^0.6.14"

✅ Appropriate caret range for minor/patch updates
✅ Added to devDependencies (correct scope)

web/.prettierrc.mjs:10:

plugins: ['@ianvs/prettier-plugin-sort-imports', 'prettier-plugin-tailwindcss']

✅ Correct plugin order (import sorting before class sorting)
✅ Maintains existing import organization rules

unraid-ui/.prettierrc.json:6:

"plugins": ["@ianvs/prettier-plugin-sort-imports", "prettier-plugin-tailwindcss"]

✅ Consistent configuration across packages
✅ Same proper plugin ordering

unraid-ui/package.json:99:

"prettier-plugin-tailwindcss": "^0.6.14"

✅ Version consistency across packages
✅ Proper dependency scope

pnpm-lock.yaml:

✅ Standard lockfile updates with proper dependency resolution

🎯 Recommendations

Immediate actions:
- ✅ Ready to merge as-is
- Consider running pnpm --filter ./web lint:fix and pnpm --filter ./unraid-ui lint:fix to format existing files
Optional enhancements:
- Could add a note in project docs about automatic Tailwind class sorting
- Consider adding to the root .prettierrc if other packages start using Tailwind
Future considerations:
- Monitor for new plugin versions with additional Tailwind v4 optimizations

🏆 Summary

This is a high-quality, low-risk change that will improve developer experience and code consistency. The implementation follows all best practices and integrates seamlessly with the existing toolchain.

Verdict: ✅ Approved - Ready for merge

github-actions · 2025-08-04T17:14:35Z

🚀 Storybook has been deployed to staging: https://unraid-ui-storybook-staging.unraid-workers.workers.dev

github-actions · 2025-08-27T20:15:27Z

🚀 Storybook has been deployed to staging: https://unraid-ui-storybook-staging.unraid-workers.workers.dev

github-actions · 2025-08-27T20:18:11Z

🚀 Storybook has been deployed to staging: https://unraid-ui-storybook-staging.unraid-workers.workers.dev

github-actions · 2025-08-27T20:23:25Z

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1562/dynamix.unraid.net.plg

🤖 I have created a release *beep* *boop* --- ## [4.17.0](v4.16.0...v4.17.0) (2025-08-27) ### Features * add tailwind class sort plugin ([#1562](#1562)) ([ab11e7f](ab11e7f)) ### Bug Fixes * cleanup obsoleted legacy api keys on api startup (cli / connect) ([#1630](#1630)) ([6469d00](6469d00)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

mdatelle requested a review from elibosley August 4, 2025 15:13

mdatelle requested review from pujitm and zackspear August 4, 2025 15:13

coderabbitai bot approved these changes Aug 4, 2025

View reviewed changes

elibosley force-pushed the feat/add-tailwind-class-sort-plugin branch from 4ea74e1 to e9a4932 Compare August 27, 2025 20:11

mdatelle and others added 4 commits August 27, 2025 16:15

feat: install and add prettier-plugin-tailwindcss to config

1b3fbc2

feat: add prettier-plugin-tailwindcss to unraid-ui

7a0b735

chore: update eslint to warn instead of error

d2030b9

chore: update prettier-plugin-tailwindcss to version 0.6.14

25725a3

elibosley force-pushed the feat/add-tailwind-class-sort-plugin branch from 96b1d99 to 25725a3 Compare August 27, 2025 20:15

fix: update deps

7a6b0bf

elibosley merged commit ab11e7f into main Aug 27, 2025
13 checks passed

elibosley deleted the feat/add-tailwind-class-sort-plugin branch August 27, 2025 20:26

github-actions bot mentioned this pull request Aug 27, 2025

chore(main): release 4.17.0 #1631

Merged

github-actions bot mentioned this pull request Oct 27, 2025

chore(main): release 4.26.0 #1744

Open

Uh oh!

feat: add tailwind class sort plugin #1562

feat: add tailwind class sort plugin #1562

Uh oh!

Conversation

mdatelle commented Aug 4, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

claude bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review: Tailwind Class Sort Plugin

Todo List

Critical Issue Analysis

Uh oh!

claude bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review: Tailwind Class Sort Plugin

Todo List

✅ Code Quality & Best Practices

🔧 Technical Analysis

🚀 Performance Considerations

🔒 Security Assessment

🧪 Test Coverage Considerations

📊 File-by-File Analysis

🎯 Recommendations

🏆 Summary

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

claude bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review: Tailwind Class Sort Plugin

Todo List

✅ Code Quality & Best Practices

🔧 Technical Analysis

🚀 Performance Considerations

🔒 Security Assessment

🧪 Test Coverage Considerations

📊 File-by-File Analysis

🎯 Recommendations

🏆 Summary

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 27, 2025

Uh oh!

github-actions bot commented Aug 27, 2025

Uh oh!

github-actions bot commented Aug 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mdatelle commented Aug 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

claude bot commented Aug 4, 2025 •

edited

Loading

claude bot commented Aug 4, 2025 •

edited

Loading

claude bot commented Aug 4, 2025 •

edited

Loading