Skip to content

feat: connect storybook with figma #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

feat: connect storybook with figma #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a5cccdd
feat: install designs addon and configure storybook
Mar 13, 2025
4fc60dc
chore: add pnpm lock file
Mar 13, 2025
c4d4860
refactor: convert badge classes to tailwind standard
Mar 17, 2025
c4df56c
refactor: add brand variants to the regulr button
Mar 18, 2025
d06ec6f
refactor: simplify Button component and begin BrandButton swap out.
Apr 1, 2025
c2f1cc8
fix: remove unused import
Apr 1, 2025
6e98e3b
fix: remove obsolete variable for button
Apr 1, 2025
82a04c5
refactor: use new new button variants in updated components
Apr 1, 2025
8dba62c
chore: remove brittle tests
Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions api/src/__test__/core/utils/array/array-is-running.test.ts
View file
Open in desktop

This file was deleted.

97 changes: 94 additions & 3 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 12 additions & 12 deletions unraid-ui/.storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,25 @@
import { dirname, join } from "path";
import type { StorybookConfig } from "@storybook/vue3-vite";

import { dirname, join } from 'path';
import type { StorybookConfig } from '@storybook/vue3-vite';

const config: StorybookConfig = {
stories: ["../stories/**/*.stories.@(js|jsx|ts|tsx)"],
stories: ['../stories/**/*.stories.@(js|jsx|ts|tsx)'],
addons: [
"@storybook/addon-links",
"@storybook/addon-essentials",
"@storybook/addon-interactions"
'@storybook/addon-links',
'@storybook/addon-essentials',
'@storybook/addon-interactions',
'@storybook/addon-designs',
],
framework: {
name: "@storybook/vue3-vite",
name: '@storybook/vue3-vite',
options: {
docgen: "vue-component-meta",
docgen: 'vue-component-meta',
},
},
core: {
builder: "@storybook/builder-vite",
builder: '@storybook/builder-vite',
},
docs: {
autodocs: "tag",
autodocs: 'tag',
},
async viteFinal(config) {
config.root = dirname(require.resolve('@storybook/builder-vite'));
Expand All @@ -46,4 +46,4 @@ const config: StorybookConfig = {
},
};

export default config;
export default config;
1 change: 1 addition & 0 deletions unraid-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
},
"devDependencies": {
"@ianvs/prettier-plugin-sort-imports": "^4.4.1",
"@storybook/addon-designs": "^8.2.1",
"@storybook/addon-essentials": "^8.5.8",
"@storybook/addon-interactions": "^8.5.8",
"@storybook/addon-links": "^8.5.8",
Expand Down
18 changes: 9 additions & 9 deletions unraid-ui/src/components/brand/BrandButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<script setup lang="ts">
import { computed } from 'vue';
import { type BrandButtonVariants, brandButtonVariants } from './brand-button.variants';
import { cn } from '@/lib/utils';
import { computed } from 'vue';
import { brandButtonVariants, type BrandButtonVariants } from './brand-button.variants';

export interface BrandButtonProps {
variant?: BrandButtonVariants['variant'];
Expand Down Expand Up @@ -43,7 +43,10 @@ const classes = computed(() => {
const iconSize = `w-${props.size}`;

return {
button: cn(brandButtonVariants({ variant: props.variant, size: props.size, padding: props.padding }), props.class),
button: cn(
brandButtonVariants({ variant: props.variant, size: props.size, padding: props.padding }),
props.class
),
icon: `${iconSize} fill-current flex-shrink-0`,
};
});
Expand Down Expand Up @@ -74,11 +77,7 @@ const needsBrandGradientBackground = computed(() => {
class="absolute -top-[2px] -right-[2px] -bottom-[2px] -left-[2px] -z-10 bg-gradient-to-r from-unraid-red to-orange opacity-0 transition-all rounded-md group-hover:opacity-100 group-focus:opacity-100"
/>

<component
:is="icon"
v-if="icon"
:class="classes.icon"
/>
<component :is="icon" v-if="icon" :class="classes.icon" />

{{ text }}
<slot />
Expand All @@ -88,7 +87,8 @@ const needsBrandGradientBackground = computed(() => {
v-if="iconRight"
:class="[
classes.icon,
iconRightHoverDisplay && 'opacity-0 group-hover:opacity-100 group-focus:opacity-100 transition-all',
iconRightHoverDisplay &&
'opacity-0 group-hover:opacity-100 group-focus:opacity-100 transition-all',
]"
/>
</component>
Expand Down
Loading