fix: make scripts executable when building the plugin #1255

elibosley · 2025-03-19T16:22:05Z

Summary by CodeRabbit

New Features
- Enhanced script functionality to automatically set correct executable permissions for files within "scripts" directories, ensuring that all relevant scripts run as expected.
- Added symbolic link management for various Node.js binaries, improving accessibility and organization within the application.

coderabbitai · 2025-03-19T16:22:14Z

Walkthrough

The pull request introduces a command in the plugin/scripts/makepkg script that targets "scripts" directories, using find to locate files and applying chmod +x to make them executable. Additionally, it modifies the plugin/source/dynamix.unraid.net/install/doinst.sh script to create symbolic links for various Node.js binaries, ensuring they point to the correct locations. No changes were made to the declarations of exported or public entities.

Changes

File	Change Summary
plugin/scripts/makepkg	Added a command to locate files in "scripts" directories and modify file permissions to be executable.
plugin/source/dynamix.unraid.net/install/doinst.sh	Created symbolic links for various Node.js binaries, removing existing binaries and linking to new ones.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant M as Makepkg Script
    participant FS as File System

    U->>M: Run makepkg
    M->>FS: Set directory permissions (chmod 755)
    M->>FS: Find files in "scripts" directories
    FS-->>M: Return list of files
    M->>FS: Set file permissions (chmod +x)

Suggested reviewers

mdatelle
pujitm

Poem

In the realm of code so bright,
A new command sets files alight,
Through "scripts" it finds each hidden gem,
Making them executable, a fresh diadem,
Cheers to tweaks that code our night!
🚀🎉

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

plugin/scripts/makepkg (1)
394-394: Great addition to make script files executable.

The added command solves the problem described in the PR by finding all files within any "scripts" directory and making them executable. However, a few improvements could make it more consistent with the surrounding code:
-  $SUDO find . -type d -name scripts -exec find {} -type f -exec chmod +x {} + \;
+  $SUDO find . -type d -name scripts -exec find {} -type f -exec chmod +x {} + \; || exit 1
Consider adding error handling with || exit 1 to be consistent with the commands on lines 393 and 395. This ensures the script fails if the chmod operation fails.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 33a1a1d and fe80bda.

📒 Files selected for processing (1)

plugin/scripts/makepkg (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: Test API
GitHub Check: Build Web App
GitHub Check: Build API
GitHub Check: Cloudflare Pages

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

plugin/source/dynamix.unraid.net/install/doinst.sh (2)

317-418: Improve error handling for directory transitions.

The new commands from lines 317 to 418 repeatedly use cd without verifying that the directory change succeeded. This may lead to unpredictable behavior if the target directory (usr/local/unraid-api/node_modules/.bin) does not exist or fails to change. Consider updating each command to use the pattern cd usr/local/unraid-api/node_modules/.bin || exit; (or another appropriate error handling mechanism) before executing subsequent commands.

🧰 Tools

🪛 Shellcheck (0.10.0)

[warning] 317-317: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 318-318: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 319-319: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 320-320: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 321-321: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 322-322: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 323-323: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 324-324: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 325-325: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 326-326: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 327-327: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 328-328: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 329-329: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 330-330: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 331-331: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 332-332: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 333-333: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 334-334: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 335-335: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 336-336: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 337-337: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 338-338: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 339-339: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 340-340: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 341-341: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 342-342: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 343-343: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 344-344: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 345-345: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 346-346: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 347-347: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 348-348: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 349-349: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 350-350: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 351-351: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 352-352: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 353-353: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 354-354: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 355-355: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 356-356: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 357-357: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 358-358: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 359-359: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 360-360: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 361-361: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 362-362: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 363-363: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 364-364: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 365-365: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 366-366: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 367-367: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 368-368: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 369-369: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 370-370: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 371-371: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 372-372: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 373-373: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 374-374: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 375-375: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 376-376: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 377-377: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 378-378: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 379-379: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 380-380: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 381-381: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 382-382: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 383-383: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 384-384: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 385-385: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 386-386: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 387-387: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 388-388: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 389-389: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 390-390: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 391-391: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 392-392: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 393-393: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 394-394: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 395-395: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 396-396: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 397-397: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 398-398: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 399-399: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 400-400: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 401-401: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 402-402: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 403-403: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 404-404: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 405-405: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 406-406: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 407-407: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 408-408: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 409-409: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 410-410: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 411-411: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 412-412: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 413-413: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 414-414: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 415-415: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 416-416: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 417-417: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 418-418: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

317-418: Consider refactoring repetitive commands for maintainability.

Many of these commands follow an identical pattern (changing directory followed by file removal and symbolic link creation). Refactoring this repetitive logic into a loop or a helper function would simplify future updates and reduce the risk of inconsistencies.

🧰 Tools

🪛 Shellcheck (0.10.0)

[warning] 317-317: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 318-318: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 319-319: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 320-320: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 321-321: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 322-322: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 323-323: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 324-324: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 325-325: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 326-326: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 327-327: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 328-328: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 329-329: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 330-330: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 331-331: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 332-332: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 333-333: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 334-334: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 335-335: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 336-336: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 337-337: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 338-338: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 339-339: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 340-340: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 341-341: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 342-342: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 343-343: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 344-344: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 345-345: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 346-346: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 347-347: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 348-348: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 349-349: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 350-350: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 351-351: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 352-352: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 353-353: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 354-354: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 355-355: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 356-356: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 357-357: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 358-358: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 359-359: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 360-360: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 361-361: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 362-362: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 363-363: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 364-364: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 365-365: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 366-366: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 367-367: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 368-368: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 369-369: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 370-370: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 371-371: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 372-372: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 373-373: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 374-374: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 375-375: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 376-376: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 377-377: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 378-378: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 379-379: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 380-380: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 381-381: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 382-382: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 383-383: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 384-384: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 385-385: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 386-386: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 387-387: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 388-388: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 389-389: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 390-390: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 391-391: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 392-392: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 393-393: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 394-394: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 395-395: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 396-396: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 397-397: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 398-398: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 399-399: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 400-400: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 401-401: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 402-402: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 403-403: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 404-404: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 405-405: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 406-406: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 407-407: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 408-408: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 409-409: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 410-410: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 411-411: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 412-412: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 413-413: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 414-414: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 415-415: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 416-416: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 417-417: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 418-418: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between f0f0d24 and 9fd2b63.

⛔ Files ignored due to path filters (2)

api/src/graphql/generated/api/operations.ts is excluded by !**/generated/**
api/src/graphql/generated/api/types.ts is excluded by !**/generated/**

📒 Files selected for processing (1)

plugin/source/dynamix.unraid.net/install/doinst.sh (1 hunks)

🧰 Additional context used

🪛 Shellcheck (0.10.0)

plugin/source/dynamix.unraid.net/install/doinst.sh

[warning] 317-317: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 318-318: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 319-319: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 320-320: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 321-321: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 322-322: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 323-323: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 324-324: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 325-325: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 326-326: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 327-327: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 328-328: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 329-329: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 330-330: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 331-331: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 332-332: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 333-333: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 334-334: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 335-335: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 336-336: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 337-337: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 338-338: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 339-339: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 340-340: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 341-341: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 342-342: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 343-343: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 344-344: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 345-345: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 346-346: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 347-347: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 348-348: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 349-349: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 350-350: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 351-351: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 352-352: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 353-353: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 354-354: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 355-355: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 356-356: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 357-357: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 358-358: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 359-359: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 360-360: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 361-361: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 362-362: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 363-363: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 364-364: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 365-365: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 366-366: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 367-367: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 368-368: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 369-369: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 370-370: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 371-371: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 372-372: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 373-373: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 374-374: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 375-375: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 376-376: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 377-377: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 378-378: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 379-379: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 380-380: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 381-381: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 382-382: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 383-383: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 384-384: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 385-385: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 386-386: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 387-387: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 388-388: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 389-389: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 390-390: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 391-391: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 392-392: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 393-393: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 394-394: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 395-395: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 396-396: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 397-397: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 398-398: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 399-399: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 400-400: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 401-401: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 402-402: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 403-403: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 404-404: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 405-405: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 406-406: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 407-407: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 408-408: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 409-409: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 410-410: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 411-411: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 412-412: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 413-413: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 414-414: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 415-415: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 416-416: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 417-417: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 418-418: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: Build Web App
GitHub Check: Build API
GitHub Check: Test API
GitHub Check: Cloudflare Pages

github-actions · 2025-03-19T17:32:02Z

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1255/dynamix.unraid.net.plg

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

plugin/source/dynamix.unraid.net/install/doinst.sh (1)
317-508: Reduce code duplication by refactoring repeated commands.

The diff introduces a large number of nearly identical commands that remove an existing binary and create a new symbolic link. This extensive repetition makes the script harder to maintain. Consider defining a helper function (or using a loop structure) that accepts the target directory, source path, and link name as parameters. This refactoring would not only cut down on duplication but also help enforce consistent error handling (such as the recommended cd ... || exit 1 mechanism).

For example, you could refactor a portion of the script as follows:
+do_link() {
+  dir="$1"
+  src="$2"
+  target="$3"
+  cd "$dir" || exit 1
+  rm -rf "$target"
+  ln -sf "$src" "$target"
+}
+
+# Replace repetitive commands with calls to do_link:
+do_link "usr/local/unraid-api/node_modules/.bin" "../@apollo/protobufjs/bin/pbjs" "apollo-pbjs"
+do_link "usr/local/unraid-api/node_modules/.bin" "../@apollo/protobufjs/bin/pbts" "apollo-pbts"
+do_link "usr/local/unraid-api/node_modules/.bin" "../blessed/bin/tput.js" "blessed"
+do_link "usr/local/unraid-api/node_modules/.bin" "../esbuild/bin/esbuild" "esbuild"
+...
This change would improve both readability and maintainability.

🧰 Tools

🪛 Shellcheck (0.10.0)

[warning] 317-317: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 318-318: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 319-319: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 320-320: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 321-321: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 322-322: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 323-323: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 324-324: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 325-325: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 326-326: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 327-327: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 328-328: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 329-329: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 330-330: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 331-331: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 332-332: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 333-333: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 334-334: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 335-335: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 336-336: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 337-337: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 338-338: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 339-339: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 340-340: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 341-341: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 342-342: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 343-343: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 344-344: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 345-345: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 346-346: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 347-347: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 348-348: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 349-349: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 350-350: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 351-351: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 352-352: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 353-353: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 354-354: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 355-355: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 356-356: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 357-357: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 358-358: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 359-359: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 360-360: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 361-361: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 362-362: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 363-363: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 364-364: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 365-365: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 366-366: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 367-367: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 368-368: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 369-369: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 370-370: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 371-371: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 372-372: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 373-373: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 374-374: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 375-375: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 376-376: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 377-377: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 378-378: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 379-379: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 380-380: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 381-381: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 382-382: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 383-383: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 384-384: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 385-385: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 386-386: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 387-387: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 388-388: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 389-389: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 390-390: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 391-391: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 392-392: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 393-393: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 394-394: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 395-395: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 396-396: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 397-397: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 398-398: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 399-399: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 400-400: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 401-401: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 402-402: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 403-403: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 404-404: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 405-405: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 406-406: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 407-407: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 408-408: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 409-409: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 410-410: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 411-411: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 412-412: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 413-413: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 414-414: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 415-415: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 416-416: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 417-417: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 418-418: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 419-419: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 420-420: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 421-421: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 422-422: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 423-423: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 424-424: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 425-425: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 426-426: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 427-427: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 428-428: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 429-429: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 430-430: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 431-431: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 432-432: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 433-433: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 434-434: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 435-435: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 436-436: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 437-437: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 438-438: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 439-439: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 440-440: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 441-441: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 442-442: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 443-443: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 444-444: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 445-445: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 446-446: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 447-447: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 448-448: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 449-449: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 450-450: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 451-451: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 452-452: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 453-453: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 454-454: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 455-455: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 456-456: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 457-457: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 458-458: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 459-459: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 460-460: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 461-461: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 462-462: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 463-463: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 464-464: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 465-465: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 466-466: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 467-467: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 468-468: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 469-469: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 470-470: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 471-471: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 472-472: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 473-473: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 474-474: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 475-475: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 476-476: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 477-477: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 478-478: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 479-479: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 480-480: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 481-481: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 482-482: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 483-483: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 484-484: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 485-485: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 486-486: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 487-487: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 488-488: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 489-489: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 490-490: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 491-491: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 492-492: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 493-493: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 494-494: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 495-495: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 496-496: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 497-497: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 498-498: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 499-499: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 500-500: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 501-501: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 502-502: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 503-503: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 504-504: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 505-505: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 506-506: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 507-507: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 508-508: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 9fd2b63 and 871c4ec.

📒 Files selected for processing (2)

plugin/scripts/makepkg (1 hunks)
plugin/source/dynamix.unraid.net/install/doinst.sh (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

plugin/scripts/makepkg

🧰 Additional context used

🪛 Shellcheck (0.10.0)

plugin/source/dynamix.unraid.net/install/doinst.sh

[warning] 317-317: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 318-318: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 319-319: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 320-320: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 321-321: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 322-322: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 323-323: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 324-324: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 325-325: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 326-326: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 327-327: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 328-328: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 329-329: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 330-330: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 331-331: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 332-332: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 333-333: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 334-334: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 335-335: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 336-336: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 337-337: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 338-338: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 339-339: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 340-340: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 341-341: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 342-342: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 343-343: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 344-344: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 345-345: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 346-346: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 347-347: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 348-348: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 349-349: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 350-350: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 351-351: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 352-352: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 353-353: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 354-354: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 355-355: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 356-356: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 357-357: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 358-358: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 359-359: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 360-360: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 361-361: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 362-362: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 363-363: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 364-364: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 365-365: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 366-366: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 367-367: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 368-368: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 369-369: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 370-370: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 371-371: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 372-372: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 373-373: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 374-374: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 375-375: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 376-376: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 377-377: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 378-378: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 379-379: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 380-380: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 381-381: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 382-382: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 383-383: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 384-384: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 385-385: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 386-386: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 387-387: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 388-388: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 389-389: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 390-390: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 391-391: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 392-392: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 393-393: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 394-394: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 395-395: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 396-396: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 397-397: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 398-398: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 399-399: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 400-400: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 401-401: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 402-402: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 403-403: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 404-404: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 405-405: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 406-406: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 407-407: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 408-408: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 409-409: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 410-410: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 411-411: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 412-412: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 413-413: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 414-414: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 415-415: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 416-416: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 417-417: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 418-418: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 419-419: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 420-420: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 421-421: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 422-422: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 423-423: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 424-424: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 425-425: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 426-426: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 427-427: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 428-428: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 429-429: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 430-430: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 431-431: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 432-432: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 433-433: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 434-434: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 435-435: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 436-436: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 437-437: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 438-438: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 439-439: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 440-440: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 441-441: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 442-442: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 443-443: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 444-444: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 445-445: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 446-446: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 447-447: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 448-448: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 449-449: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 450-450: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 451-451: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 452-452: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 453-453: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 454-454: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 455-455: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 456-456: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 457-457: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 458-458: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 459-459: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 460-460: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 461-461: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 462-462: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 463-463: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 464-464: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 465-465: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 466-466: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 467-467: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 468-468: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 469-469: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 470-470: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 471-471: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 472-472: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 473-473: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 474-474: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 475-475: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 476-476: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 477-477: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 478-478: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 479-479: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 480-480: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 481-481: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 482-482: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 483-483: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 484-484: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 485-485: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 486-486: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 487-487: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 488-488: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 489-489: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 490-490: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 491-491: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 492-492: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 493-493: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 494-494: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 495-495: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 496-496: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 497-497: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 498-498: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 499-499: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 500-500: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 501-501: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 502-502: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 503-503: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 504-504: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 505-505: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 506-506: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 507-507: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

[warning] 508-508: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

(SC2164)

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: Build Web App
GitHub Check: Build API
GitHub Check: Test API
GitHub Check: Cloudflare Pages

plugin/source/dynamix.unraid.net/install/doinst.sh

🤖 I have created a release *beep* *boop* --- ## [4.4.0](v4.3.1...v4.4.0) (2025-03-25) ### Features * add ReplaceKey functionality to plugin ([#1264](#1264)) ([4aadcef](4aadcef)) * downgrade page replace key check ([#1263](#1263)) ([8d56d12](8d56d12)) * make log viewer component dynamic ([#1242](#1242)) ([e6ec110](e6ec110)) * ReplaceKey functionality in Registration and Update pages ([#1246](#1246)) ([04307c9](04307c9)) * UnraidCheckExec for Check OS Updates via UPC dropdown ([#1265](#1265)) ([5935a3b](5935a3b)) ### Bug Fixes * **deps:** update all non-major dependencies ([#1236](#1236)) ([7194f85](7194f85)) * **deps:** update all non-major dependencies ([#1247](#1247)) ([20b0aeb](20b0aeb)) * **deps:** update all non-major dependencies ([#1251](#1251)) ([33a1a1d](33a1a1d)) * **deps:** update all non-major dependencies ([#1253](#1253)) ([53fec0e](53fec0e)) * **deps:** update dependency @nestjs/passport to v11 ([#1244](#1244)) ([edc93a9](edc93a9)) * **deps:** update dependency graphql-subscriptions to v3 ([#1209](#1209)) ([c14c85f](c14c85f)) * **deps:** update dependency ini to v5 ([#1217](#1217)) ([f27660f](f27660f)) * **deps:** update dependency jose to v6 ([#1248](#1248)) ([42e3d59](42e3d59)) * **deps:** update dependency marked to v15 ([#1249](#1249)) ([2b6693f](2b6693f)) * **deps:** update dependency pino-pretty to v13 ([#1250](#1250)) ([85fb910](85fb910)) * **deps:** update dependency pm2 to v6 ([#1258](#1258)) ([04ad2bc](04ad2bc)) * **deps:** update dependency shadcn-vue to v1 ([#1259](#1259)) ([1a4fe8f](1a4fe8f)) * **deps:** update dependency vue-i18n to v11 ([#1261](#1261)) ([0063286](0063286)) * **deps:** update vueuse monorepo to v13 (major) ([#1262](#1262)) ([94caae3](94caae3)) * make scripts executable when building the plugin ([#1255](#1255)) ([e237f38](e237f38)) * node installation not persisting across reboots ([#1256](#1256)) ([0415cf1](0415cf1)) * update configValid state to ineligible in var.ini and adjust rel… ([#1268](#1268)) ([ef8c954](ef8c954)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: make scripts executable when building the plugin

fe80bda

elibosley requested a review from ljm42 March 19, 2025 16:22

ljm42 previously approved these changes Mar 19, 2025

View reviewed changes

coderabbitai bot reviewed Mar 19, 2025

View reviewed changes

fix: find command syntax invalid

f0f0d24

elibosley dismissed ljm42’s stale review via f0f0d24 March 19, 2025 16:35

feat: enable execution of unraidcheck and gitflash_log

9fd2b63

elibosley requested review from mdatelle and pujitm as code owners March 19, 2025 17:24

chore: cleanup find command

871c4ec

coderabbitai bot reviewed Mar 19, 2025

View reviewed changes

plugin/source/dynamix.unraid.net/install/doinst.sh Show resolved Hide resolved

elibosley merged commit e237f38 into main Mar 20, 2025
8 checks passed

elibosley deleted the fix/make-scripts-executable branch March 20, 2025 01:13

github-actions bot mentioned this pull request Mar 20, 2025

chore(main): release 4.4.0 #1241

Merged

This was referenced Mar 25, 2025

chore(main): release 4.4.1 #1270

Merged

chore(main): release 4.5.0 #1276

Closed

chore(main): release 4.5.0 #1279

Merged

This was referenced Apr 2, 2025

chore(main): release 4.6.0 #1311

Merged

chore(main): release 4.6.1 #1322

Merged

chore(main): release 4.6.2 #1323

Merged

chore(main): release 4.6.3 #1324

Merged

chore(main): release 4.6.4 #1325

Merged

github-actions bot mentioned this pull request Oct 27, 2025

chore(main): release 4.26.0 #1744

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: make scripts executable when building the plugin #1255

fix: make scripts executable when building the plugin #1255

Uh oh!

elibosley commented Mar 19, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 19, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

github-actions bot commented Mar 19, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix: make scripts executable when building the plugin #1255

fix: make scripts executable when building the plugin #1255

Uh oh!

Conversation

elibosley commented Mar 19, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 19, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

elibosley commented Mar 19, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 19, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)