Skip to content

fix(web): tailwind setup errors #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

fix(web): tailwind setup errors #1071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
97d98bc
chore(ui): add justfile to simplify setup
pujitm Jan 17, 2025
8af1098
chore: update vulnerable dependencies
pujitm Jan 17, 2025
7fdf277
fix(ui): tailwind config compatibility & types
pujitm Jan 17, 2025
4b5442d
chore(ui): expose & use typescript tailwind config in `web`
pujitm Jan 17, 2025
dd8dc9e
chore(ui): add typescript tailwind config to build artifact
pujitm Jan 17, 2025
e1a8d95
chore: mv tw plugins to dependencies
pujitm Jan 17, 2025
67c796b
hack(ui): force preservation of tailwind plugins
pujitm Jan 21, 2025
2fb2e4e
add tw plugins to web
pujitm Jan 21, 2025
fc895fb
fix: build-web workflow
pujitm Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@ jobs:
run: |
mkdir unraid-ui-dist
mv dist/ unraid-ui-dist/dist/
mv src unraid-ui-dist/src
ln -s unraid-ui-dist/dist/node_modules unraid-ui-dist/node_modules
mv tailwind.config.ts unraid-ui-dist/tailwind.config.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

⚠️ Warning: tailwind.config.ts file not found in repository

The workflow attempts to move tailwind.config.ts to the distribution directory, but the file does not exist in the repository root. This will cause the build to fail unless:

  • The file is generated during the build process
  • The file exists in a different location

Please verify:

  • The file's existence and location
  • If it should be generated during build, ensure the generation step is added before the move operation
🔗 Analysis chain

LGTM! Including Tailwind config in the build artifact.

The change correctly ensures that the Tailwind configuration is included in the distribution package, which aligns with fixing the Tailwind setup errors.

Let's verify that the Tailwind config is properly included in the build artifact:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the contents of the unraid-ui build artifact
# Expected: Should find tailwind.config.ts in the artifact

# List files in the most recent unraid-ui artifact
gh run download --name unraid-ui --dir /tmp/unraid-ui
ls -la /tmp/unraid-ui/unraid-ui-dist/tailwind.config.ts

Length of output: 357

Script:

#!/bin/bash
# Check if the source file exists and examine workflow structure
echo "=== Checking source file ==="
ls -la tailwind.config.ts

echo -e "\n=== Examining workflow steps ==="
cat .github/workflows/main.yml | grep -A 10 -B 10 "mv tailwind.config.ts"

Length of output: 876

mv package.json unraid-ui-dist/package.json
ls unraid-ui-dist

Expand Down Expand Up @@ -167,19 +170,12 @@ jobs:
cache-dependency-path: |
web/package-lock.json
node-version-file: "web/.nvmrc"

- name: Setup Just
uses: extractions/setup-just@v2

- name: Remove Existing Unraid UI folder
run: |
rm -r ../unraid-ui

- name: Download Artifact for Unraid UI
uses: actions/download-artifact@v4
with:
name: unraid-ui
path: unraid-ui

- name: Installing node deps
run: npm install
- name: Installing deps
run: just setup

- name: Lint files
continue-on-error: true
Expand Down
13 changes: 13 additions & 0 deletions unraid-ui/justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
default: list-commands

list-commands:
@just --list --justfile {{justfile()}} --list-heading $'\nMonorepo recipes:\n'

# Prepares the repo for development
setup:
npm install
npm run build

clean:
npm run clean
rm -rf node_modules
Loading
Loading