Local Access Fails If Remote Access Has Been Turned On and Then Off Previously

[jaron-l]

Environment

Unraid OS Version:

7.1.4

Are you using a reverse proxy?

No

Pre-submission Checklist

• [ x ] I have verified that my Unraid OS is up to date I tested on 7.0.1 and 7.1.4
• [ x ] I have tested this issue by accessing my server directly (not through a reverse proxy) local ip works
• [ x ] This is not an Unraid Connect related issue (if it is, please submit via the support form instead)

Issue Description

After enabling remote access and then disabling it (so the server should only be accessible on the LAN), there is a port still present in the settings file (/boot/config/plugins/dynamix.my.servers/config/connect.json) and in the UI. That port number is used in the URL for accessing the server's UI through connect (..myunraid.net:), which won't work for local access as for local access, the port should be 443. This makes it so the server is now inaccessible through connect.myunraid.net. When browsing to the url manually (not through connect.myunraid.net but directly to ..my unRAID.net), the server is still accessible.

A manual workaround I've used is to:

1. Set the remote access to "DISABLED" in the connect API settings
2. run unraid-api stop on the server
3. delete the line "wanport": <number>, from the file /boot/config/plugins/dynamix.my.servers/configs/connect.json
4. run unraid-api stop on the server

This manually removes the port number from the connect settings and allows connect.myunraid.net to access your server again on LAN.

I'm not sure what the intended workflow should be, either preserve the port in the settings file but don't use it when generating the URL for accessing the server on LAN, or remove the port number and then it can't be used to generate the LAN URL.

I briefly looked into what might be the issue. It does seem that this line:

api/packages/unraid-api-plugin-connect/src/unraid-connect/connect-settings.service.ts

Line 127 in b2e7801

settings.port = null;

was intended to make it so that the port number would be null-ified when remote access is disabled but for some reason, that doesn't appear to run or otherwise remove the port from the settings file.

Steps to Reproduce

Assumes you can currently connect through connect.myunraid.net
Enable remote access with UPnP
Disable remote access
Refresh your browser page and observe that you can no longer access your server through connect

Expected Behavior

When disabling remote access, the server should still be accessible through connect.myunraid.net if you are on the same LAN.

Actual Behavior

When disabling remote access in the connect settings, the server is no longer available through connect.myunraid.net when on the same LAN.

Additional Context

[pujitm]

the line callout made this really easy. thanks for reporting this 👑