fix: dts path #398
Merged
fix: dts path #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
May 24, 2022
| @@ -51,8 +51,7 @@ | |||
| } | |||
| }, | |||
| "files": [ | |||
| "dist", | |||
| "*.d.ts" | |||
| "dist" | |||
There was a problem hiding this comment.
Hmmm seems there's no d.ts file on the root level directory, so no difference.
There was a problem hiding this comment.
Yeah but why types are pointing to index.d.ts?
There was a problem hiding this comment.
Would this work? https://antfu.me/notes#types-for-sub-modules
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
sxzz
commented
May 24, 2022
| @@ -51,8 +51,7 @@ | |||
| } | |||
| }, | |||
| "files": [ | |||
| "dist", | |||
| "*.d.ts" | |||
| "dist" | |||
| ], | |||
| "typesVersions": { | |||
There was a problem hiding this comment.
You already config path alias here typesVersions. So it will pointing to ./dist/dist/index.d.ts
|
@antfu 🤔 Is this PR acceptable for you? Or do you have any other questions that I can answer? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.