Skip to content

fix: support numeric filter when search query is empty #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mskutle wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: support numeric filter when search query is empty #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11bd685
fix: support numeric filter when search query is empty
Nov 14, 2025
5687d3f
chore: revert changes to adaptRequest
Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 19 additions & 2 deletions src/adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,33 @@ export function performSearch(
let processingTimeMS = 0;
const responses = requests.map((request) => {
const adaptedRequest = adaptRequest(request);
const itemsJsRes = index.search(adaptedRequest);

// Save the filter function and remove it temporarily if query is empty
// because itemsjs doesn't work with filter function on empty query
const numericFilter = adaptedRequest.filter;
if (!request.params.query && numericFilter) {
delete adaptedRequest.filter;
}

const itemsJsRes = index.search(adaptedRequest);
processingTimeMS = processingTimeMS + itemsJsRes.timings.total;

// Apply numeric filter post-search if query was empty
if (!request.params.query && numericFilter && itemsJsRes.data.items) {
itemsJsRes.data.items = itemsJsRes.data.items.filter(numericFilter);
// Also update pagination total
itemsJsRes.pagination.total = itemsJsRes.data.items.length;
}

// Are there any aggregations?
if (itemsJsRes.data.aggregations) {
// Only copy the requested aggregations
const filteredAggregations = {};
const facets = request.params.facets
? Array.from(request.params.facets)
: [];
Object.keys(itemsJsRes.data.aggregations).forEach((aggregationName) => {
if (request.params.facets.includes(aggregationName)) {
if (facets.indexOf(aggregationName) !== -1) {
filteredAggregations[aggregationName] =
itemsJsRes.data.aggregations[aggregationName];
}
Expand Down