Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed missing Xaml IntelliSense on newly created project #2365

Merged
merged 2 commits into from
Jan 24, 2020
Merged

fixed missing Xaml IntelliSense on newly created project #2365

merged 2 commits into from
Jan 24, 2020

Conversation

XiaotianNetlift
Copy link
Contributor

GitHub Issue (If applicable): #2364

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When you create a new Cross-Platform App (Uno Platform) and open the MainPage.xaml, there is the Xaml IntelliSense support is missing.

What is the new behavior?

Xaml IntelliSense should just work.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@gitpod-io
Copy link

gitpod-io bot commented Dec 19, 2019 •
edited
Loading

@github-actions github-actions bot added area/solution-templates Categorizes an issue or PR as relevant to the solution template kind/documentation labels Dec 19, 2019
@XiaotianNetlift XiaotianNetlift force-pushed the dev/xygu/2364/new-proj-xaml-intellisense branch from ca9e838 to da6671b Compare December 19, 2019 15:48
@XiaotianNetlift XiaotianNetlift changed the title fixed Xaml IntelliSense on newly created project fixed missing Xaml IntelliSense on newly created project Dec 19, 2019
@agneszitte
Copy link
Contributor

Oh yeah ❤️ !!

@nventive-devops
Copy link
Contributor

The build 11039 found UI Test snapshots differences.

  • android-28: 6 changed over 218

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_3_-_Orientation_Portrait
    • Keyboard_Textbox_InsideScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
    • ToggleSwitch_TemplateReuseTest_UITests_Shared_Windows_UI_Xaml_Controls_ToggleSwitchControl_ToggleSwitch_TemplateReuse
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • TestManipulation_Result
    • TextBox_RoundedCorners_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_RoundedCorners

  • android-28-Snap: 629 changed over 629

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Animations_DoubleAnimationUsingKeyFrames_TranslateX_GenericApp_Views_Content_UITests_Animations_DoubleAnimationUsingKeyFrames_TranslateX
    • Animations_DoubleAnimation_Cumulative_Uno_UI_Samples_Content_UITests_Animations_DoubleAnimation_Cumulative
    • Animations_DoubleAnimation_RenderTransformOrigin_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_RenderTransformOrigin
    • Animations_DoubleAnimation_VisualStates_Uno_UI_Samples_Content_UITests_Animations_DoubleAnimation_VisualStates
    • Automation_AutomationProperties_AutomationId_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_AutomationId
    • AutoSuggestBox_BasicAutoSuggestBox_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_BasicAutoSuggestBox
    • Border_AutoBorderStretchwithbottommargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithbottommargin
    • Border_AutoBorderStretchwithrightmargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithrightmargin
    • Border_BorderCenteredwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderCenteredwithmargins
    • Border_BorderLeftwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderLeftwithmargins
    • Border_Border_CornerRadius_Alignments_Uno_UI_Samples_UITests_BorderTestsControl_Border_CornerRadius_Alignments
    • Border_Border_CornerRadius_Binding_Uno_UI_Samples_UITests_BorderTestsControl_Border_CornerRadius_Binding
    • Border_Border_Corner_Overlap_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerOverlap
    • Border_Border_Simple_No_Background_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_No_Background
    • Border_Border_Simple_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple
    • Border_Border_Simple_with_non_Uniform_Thickness_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_with_non_Uniform_Thickness
    • Border_Circle_Uno_UI_Samples_UITests_BorderTestsControl_Circle
    • Border_NonUniformThicknessandRadius_Uno_UI_Samples_UITests_BorderTestsControl_NonUniformThicknessandRadius
    • Border_SimplewithNonUnifmormRadius_Uno_UI_Samples_UITests_BorderTestsControl_SimplewithNonUnifmormRadius
    • Border_Simple_with_Radius_Uno_UI_Samples_UITests_BorderTestsControl_Simple_with_Radius

  • ios: 7 changed over 109

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • DatePickerFlyout_Unloaded_UITests_Shared_Windows_UI_Xaml_Controls_DatePicker_DatePicker_SampleContent
    • Keyboard_Textbox_InsideScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
    • Keyboard_Textbox_InsideScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
    • Keyboard_Textbox_InsideScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
    • Keyboard_Textbox_InsideScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox

  • ios-Snap: 3 changed over 620

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • BitmapIcon_BitmapIcon_Generic_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Generic
    • Default_Uno_UI_Samples_UITests_Image_Image_Stretch_Uno_UI_Samples_UITests_Image_Image_Stretch
    • TextBlockControl_TextBlock_FixedWidth_With_DataBound_Run_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_FixedWidth_With_DataBound_Run

  • wasm: 5 changed over 633

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Image
    • SamplesApp.Windows_UI_Xaml_Media.Animation.SequentialAnimationsPage
    • UITests.Shared.Windows_UI_Xaml_Automation.AutomationProperties_Name
    • Uno.UI.Samples.UITests.Image.Image_Margin
    • Uno.UI.Samples.UITests.Image.Image_Stretch

  • wasm-automated: 2 changed over 284

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • LoadEmptyContentControl_ContentControlNoTemplateNoContent_-_bntContentClear
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage

@davidjohnoliver
Copy link
Contributor

I'm curious what the entries you added do?

@XiaotianNetlift
Copy link
Contributor Author

XiaotianNetlift commented Dec 20, 2019 •
edited by unfurl-links bot
Loading

@jeromelaban @davidjohnoliver

Specifies whether to create the project and perform parameter replacement in the specified location, or perform parameter replacement in a temporary location and then save the project to the specified location.
remark: CreateInPlace is an optional element. The default value is true.
-- https://docs.microsoft.com/en-us/visualstudio/extensibility/createinplace-visual-studio-templates?view=vs-2019

I found out by comparing with other .vstemplate on the Github. Also, despite the remark is not true, it clearly made a difference when you explicitly set it to true.

@XiaotianNetlift XiaotianNetlift force-pushed the dev/xygu/2364/new-proj-xaml-intellisense branch from da6671b to c679145 Compare December 20, 2019 15:27
jeromelaban
jeromelaban approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Same question as @davidjohnoliver , how did you find those properties ?

@XiaotianNetlift
Copy link
Contributor Author

XiaotianNetlift commented Dec 20, 2019 •
edited by unfurl-links bot
Loading

Nice! Same question as @davidjohnoliver , how did you find those properties ?

I found out by comparing with other .vstemplate files on the Github. Namely those found within: https://github.com/mono/CocosSharp/tree/master/ProjectTemplates/Templates/StarterTemplates/FormsMobile/Template

GitHub
CocosSharp is a C# implementation of the Cocos2D and Cocos3D APIs that runs on any platform where MonoGame runs. - mono/CocosSharp

@jeromelaban jeromelaban added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Dec 23, 2019
@nventive-devops
Copy link
Contributor

The build 11800 found UI Test snapshots differences.

  • android-28: 5 changed over 259

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • CommandBar_LongTitle_Validation_CommandBar_-_LongTitle_-_4_-_Orientation_Landscape
    • FrameworkElement_NativeLayout_UITests_Shared_Windows_UI_Xaml_FrameworkElementTests_FrameworkElement_NativeLayout
    • PopupWithOverlay_After
    • TestManipulation_Result
    • ToggleSwitch_TemplateReuseTest_UITests_Shared_Windows_UI_Xaml_Controls_ToggleSwitchControl_ToggleSwitch_TemplateReuse

  • android-28-Snap: 11 changed over 654

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Button_ComboBox_Simple_Uno_UI_Samples_Content_UITests_ButtonTestsControl_ComboBox_Simple
    • ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement
    • Animations_Sequential_Animations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • Button_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
    • ImageBrushTestControl_ImageBrushChangingCornerRadius_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushChangingCornerRadius
    • Image_Image_Stretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • ListView_ListView_WithScrollViewer_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_WithScrollViewer
    • TextBlockControl_TextBlockMultilineInStarStackPanel_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockMultilineInStarStackPanel
    • Transform_TransformToVisual_Translate2d_SamplesApp_Wasm_Windows_UI_Xaml_Media_Transform_TransformToVisual_Translate2d
    • UIElement_TransformToVisual_Transform_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_Transform
    • TextBox_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Reveal_Scroll

  • ios: 9 changed over 115

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • DatePickerFlyout_Unloaded_UITests_Shared_Windows_UI_Xaml_Controls_DatePicker_DatePicker_SampleContent
    • Keyboard_Textbox_InsideScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
    • Keyboard_Textbox_InsideScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
    • Keyboard_Textbox_InsideScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox

  • ios-Snap: 5 changed over 645

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Default_Uno_UI_Samples_UITests_Image_Image_Stretch_Uno_UI_Samples_UITests_Image_Image_Stretch
    • MediaPlayerElement_Using__3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
    • WebView_Javascript_AlertConfirmPrompt_Uno_UI_Samples_Content_UITests_WebView_WebViewControlJavaScriptAlertConfirmPrompt
    • WebView_WebView_JavascriptInvoke_Uno_UI_Samples_Content_UITests_WebView_WebView_JavascriptInvoke
    • WebView_WebView_NavigateToUri_Uno_UI_Samples_Content_UITests_WebView_WebView_NavigateToUri

  • wasm: 2 changed over 658

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • SamplesApp.Windows_UI_Xaml_Media.Animation.SequentialAnimationsPage
    • UITests.Shared.Windows_UI_Xaml_Automation.AutomationProperties_Name

  • wasm-automated: 3 changed over 315

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Affect_Measurement_polygon_PolygonPage_-_ChangeShape-After_clear
    • LoadEmptyContentControl_ContentControlNoTemplateNoContent_-_bntContentClear
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage

@mergify mergify bot merged commit 3a4d4d0 into master Jan 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the dev/xygu/2364/new-proj-xaml-intellisense branch January 24, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

@agneszitte agneszitte agneszitte approved these changes

@MatFillion MatFillion Awaiting requested review from MatFillion

@davidjohnoliver davidjohnoliver Awaiting requested review from davidjohnoliver

Assignees
No one assigned
Labels
area/solution-templates Categorizes an issue or PR as relevant to the solution template ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XiaotianNetlift @agneszitte @nventive-devops @davidjohnoliver @jeromelaban @Xiaoy312