-
Notifications
You must be signed in to change notification settings - Fork 818
UDEI texts #21675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
UDEI texts #21675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the UDEI (Uno Development Environment Indicator) messaging system to follow a more structured specification. The changes consolidate message creation through well-known static properties and methods, improving maintainability and consistency across the codebase.
Key Changes
- Removed extension methods in favor of static factory methods for UDEI messages
- Split large message definition file into multiple partial class files for better organization
- Updated all message references to use the new centralized factory methods
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| UnoDevelopmentEnvironmentIndicatorExtensions.cs | Removed extension methods that created UDEI messages inline |
| IdeCommandHandler.cs | Added case-insensitive command name matching |
| EntryPoint.cs | Updated to use new static factory methods for UDEI messages |
| UpdateFileIdeMessage.cs | Removed unused message type |
| DevelopmentEnvironmentStatusIdeMessage.cs | Moved to UDEI subdirectory with partial class declaration |
| DevelopmentEnvironmentStatusIdeMessage.WellKnown.cs | Added static factory methods and properties for common UDEI messages |
| DevelopmentEnvironmentStatus.cs | Extracted enum to separate file in UDEI subdirectory |
| DevelopmentEnvironmentComponent.cs | Extracted record to separate file in UDEI subdirectory |
| DevelopmentEnvironmentComponent.WellKnown.cs | Moved well-known components to separate partial class file |
| DevelopmentEnvironmentStatusIdeMessage.cs (old location) | Removed original file after splitting into multiple files |
| UnoDevEnvironmentService.cs | Updated to use new static factory methods for UDEI messages |
....RemoteControl.Messaging/IDEChannel/UDEI/DevelopmentEnvironmentStatusIdeMessage.WellKnown.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI.RemoteControl.Messaging/IDEChannel/UDEI/DevelopmentEnvironmentComponent.WellKnown.cs
Outdated
Show resolved
Hide resolved
9c556cb to
c5866a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.
|
π€ Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21675/docs/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.
|
|
|
|
f270962 to
617abea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/Uno.UI.RemoteControl.Messaging/IDEChannel/UDEI/DevelopmentEnvironmentComponent.WellKnown.cs:1
- Changed 'uno' to 'Uno' for proper capitalization of the platform name.
ο»Ώnamespace Uno.UI.RemoteControl.Messaging.IdeChannel;
....RemoteControl.Messaging/IDEChannel/UDEI/DevelopmentEnvironmentStatusIdeMessage.WellKnown.cs
Show resolved
Hide resolved
|
|
|
|
|
π€ Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21675/docs/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.
|
π€ Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21675/docs/index.html |
linked to https://github.com/unoplatform/uno-private/issues/1480
β¨ Feature
Update texts to latest spec
What is the current behavior? π€
Temp dev texts
What is the new behavior? π
Follow the spec
PR Checklist β
Screenshots Compare Test Runresults.