fix(nativeelementhosting): default to zero when given infinite bounds on measuring #20574
Conversation
github-actions
bot
added
platform/wasm 🌐
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20574/docs/index.html |
| @@ -153,7 +153,16 @@ partial void DetachNativeElement(object content) | |||
| private Size MeasureNativeElement(Size childMeasuredSize, Size availableSize) | |||
| { | |||
| global::System.Diagnostics.Debug.Assert(IsNativeHost); | |||
| return _nativeElementHostingExtension.Value!.MeasureNativeElement(Content, childMeasuredSize, availableSize); | |||
| var ret = _nativeElementHostingExtension.Value!.MeasureNativeElement(Content, childMeasuredSize, availableSize); | |||
| if (ret.Width is double.PositiveInfinity or double.NaN) | |||
There was a problem hiding this comment.
Let's add a test for this, both manual and automated
There was a problem hiding this comment.
I added a runtime test but I'm not sure what to do for a manual test.
There was a problem hiding this comment.
For a manual test, since we can't screenshot the result, you can have different scenarios (grid, stackpanel, explicit height, explicit width, etc...) so that the tester can see the results on screen.
|
|
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20574/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20574/docs/index.html |
|
|
GitHub Issue (If applicable): https://github.com/unoplatform/uno-private/issues/1349
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):