fix: Namespace and logic in ProgressBarAutomationPeer
#20501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20501/wasm-skia-net9/index.html |
github-actions
bot
added
area/skia ✏️
There was a problem hiding this comment.
Pull Request Overview
This PR fixes namespace issues and refactors the implementation of the ProgressBarAutomationPeer to align with the updated logic requirements. Key changes include:
- Updating namespace declarations in several files.
- Refactoring ProgressBarAutomationPeer to inherit from RangeBaseAutomationPeer and use the Owner property.
- Introducing a TestAutomationPeerListener for testing purposes.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Uno.UI/UI/Xaml/Automation/Peers/RangeBaseAutomationPeer.cs | Updated namespace syntax to use the semicolon form. |
| src/Uno.UI/UI/Xaml/Automation/Peers/AutomationPeer.skia.cs | Adjusted getter for AutomationPeerListener to include a test listener. |
| src/Uno.UI/Microsoft/UI/Xaml/Controls/ProgressBar/ProgressBarAutomationPeer.cs | Refactored class inheritance and implementation of IRangeValueProvider to use Owner instead of a local _owner. |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ProgressBar.cs | Added tests to validate the new AutomationPeerListener behavior. |
| build/PackageDiffIgnore.xml | Updated package diff ignore settings for ProgressBarAutomationPeer. |
Comments suppressed due to low confidence (1)
src/Uno.UI/Microsoft/UI/Xaml/Controls/ProgressBar/ProgressBarAutomationPeer.cs:54
- [nitpick] Consider renaming GetImpl to GetProgressBar for improved clarity, as it clearly indicates the purpose of casting Owner to ProgressBar.
private ProgressBar GetImpl() => (ProgressBar)Owner;
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20501/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20501/docs/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20501/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20501/docs/index.html |
|
@Mergifyio backport release/stable/6.0 |
🟠 Waiting for conditions to match
|
dr1rrb
approved these changes
May 23, 2025
MartinZikmund
force-pushed
the
dev/mazi/progressbar-reg
branch
from
e275664 to
da819ab
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20501/docs/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20501/wasm-skia-net9/index.html |
|
|
MartinZikmund
force-pushed
the
dev/mazi/progressbar-reg
branch
from
da819ab to
c9c3a34
Compare
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20501/wasm-skia-net9/index.html |
|
@Mergifyio backport release/stable/6.0 |
✅ Backports have been created
|
|
The build 167251 found UI Test snapshots differences: Details
|
6 tasks
DevTKSS
pushed a commit
to DevTKSS/uno
that referenced
this pull request
May 31, 2025
jeromelaban
added a commit
that referenced
this pull request
Jun 2, 2025
…6.0/pr-20501 fix: Namespace and logic in `ProgressBarAutomationPeer` (backport #20501)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #20499
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):