fix(implicit packages):Adding MAUI and C# markup packages when enabled #18703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also found a probable typo
MartinZikmund
approved these changes
Nov 6, 2024
|
@LuisAlfredo92 please make sure to reword the commits to adhere to Conventional Commits spec https://www.conventionalcommits.org/en/v1.0.0/ |
Adding MAUI and C# Markup packages when they are selected in templates. Also, found a probable typo that could cause the original problem refs: unoplatform#18700
LuisAlfredo92
changed the title
|
I did the change, is it correct now? Or do I have to create the fork again? |
jeromelaban
reviewed
Nov 8, 2024
| @@ -44,6 +44,15 @@ | |||
| <_UnoProjectSystemPackageReference Include="Uno.Extensions.Markup.Generators" ProjectSystem="true" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="$(UnoFeatures.Contains(';mauiembedding;'))"> | |||
There was a problem hiding this comment.
It feels like this section is not required, it's a duplicate of the other section in Uno.Extensions.Implicit.Packages.ProjectSystem.targets. It's likely, though, that the bug really was the typo that you found!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also found a probable typo
GitHub Issue (If applicable): closes #18700
PR Type
What kind of change does this PR introduce?
What is the current behavior?
You have to add the NuGet package manually
What is the new behavior?
It adds it automatically to the main project
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Number of tests passed and failed didn't change
Internal Issue (If applicable): #18700