Don't allow mixing WinUI Frame behavior with native frame presenter #18460
Conversation
| // It is not possible to use the WinUI behavior with a NativeFramePresenter. | ||
| if (this.Log().IsEnabled(LogLevel.Error)) | ||
| { | ||
| this.Log().LogError("WinUI Frame behavior is not compatible with NativeFramePresenter. Set the Frame.Style to '{StaticResource XamlDefaultFrame}' instead."); |
There was a problem hiding this comment.
Should we perhaps "undo" the feature flags for NatveFramePresenter if UseWinUIBehavior for Frame is set?
There was a problem hiding this comment.
The trouble here is that in case of the Toolkit NativeFramePresenter I don't think they are set - the style coming from toolkit is set always irrespective of the flags, unless I missed something. If that is the case, then I think this solution will apply to both cases.
Secondly, you could mix WinUI and non-WinUI behavior frames in a single app (not sure why though 😀), in which case this hint may be better.
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18460/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18460/index.html |
GitHub Issue (If applicable): closes #18401
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When WinUI Frame behavior is used, content does not load correctly.
What is the new behavior?
Error log informs the user the mode is not compatible with
NativeFramePresenter- usingGetType().Nameto handle both the internalNativeFramePresenteras well as the one coming fromUno.Toolkit.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):