-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Sign-in with Apple how-to #18410
base: master
Are you sure you want to change the base?
Conversation
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18410/index.html |
It would be nice to make this also a option in our wizard/templates |
Good idea @MartinZikmund, I also wanted to make a sample to better showcase this, but this could be better. |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18410/index.html |
@MartinZikmund, @morning4coffe-dev could you please open an issue for this if one hasn't been created yet? |
Opened here: unoplatform/uno.extensions#2589 |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18410/index.html |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18410/index.html |
|
||
// Retain the delegate to prevent garbage collection | ||
_appleSignInDelegate = new AuthorizationControllerDelegate(this); | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this code be behind a
#if __IOS__
#endif
pre-compile directive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we put all of this behind #if __IOS__
I created a sample app out of this documentation, and I am getting the button on my page, but the button does not work when I click it. I feel there's some other configuration part on the Apple side that we are not telling you about. @trydalch, do you remember what kind of configuration was also required? I followed the Apple docs, and it told me to activate the AppleSignIn capability, which I did, but still. |
Looking in the Apple Developer Console, it looks like we set up the bundle ID to have the Sign In with Apple capability there as well, not just locally in the project. That is probably needed. |
GitHub Issue (If applicable): closes #18402, #18395
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
A nice to have sample with the content from our community in #18395.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):