Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Sign-in with Apple how-to #18410

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

morning4coffe-dev
Copy link
Member

@morning4coffe-dev morning4coffe-dev commented Oct 8, 2024

GitHub Issue (If applicable): closes #18402, #18395

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

What is the new behavior?

A nice to have sample with the content from our community in #18395.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@morning4coffe-dev morning4coffe-dev self-assigned this Oct 8, 2024
@morning4coffe-dev morning4coffe-dev added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2024
@github-actions github-actions bot added area/build Categorizes an issue or PR as relevant to build infrastructure kind/documentation labels Oct 8, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18410/index.html

@MartinZikmund
Copy link
Member

It would be nice to make this also a option in our wizard/templates

@morning4coffe-dev
Copy link
Member Author

Good idea @MartinZikmund, I also wanted to make a sample to better showcase this, but this could be better.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18410/index.html

@morning4coffe-dev morning4coffe-dev removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2024
@morning4coffe-dev morning4coffe-dev marked this pull request as ready for review October 13, 2024 07:59
@agneszitte
Copy link
Contributor

It would be nice to make this also a option in our wizard/templates

@MartinZikmund, @morning4coffe-dev could you please open an issue for this if one hasn't been created yet?
That way, we can address it later. Thanks in advance!

doc/articles/interop/apple-login.md Outdated Show resolved Hide resolved
doc/articles/toc.yml Outdated Show resolved Hide resolved
@morning4coffe-dev
Copy link
Member Author

It would be nice to make this also a option in our wizard/templates

@MartinZikmund, @morning4coffe-dev could you please open an issue for this if one hasn't been created yet? That way, we can address it later. Thanks in advance!

Opened here: unoplatform/uno.extensions#2589

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18410/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18410/index.html


// Retain the delegate to prevent garbage collection
_appleSignInDelegate = new AuthorizationControllerDelegate(this);
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this code be behind a

#if __IOS__

#endif

pre-compile directive?

Copy link

@trydalch trydalch Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we put all of this behind #if __IOS__

@ajpinedam
Copy link
Contributor

I created a sample app out of this documentation, and I am getting the button on my page, but the button does not work when I click it. I feel there's some other configuration part on the Apple side that we are not telling you about.

@trydalch, do you remember what kind of configuration was also required? I followed the Apple docs, and it told me to activate the AppleSignIn capability, which I did, but still.

@trydalch
Copy link

Looking in the Apple Developer Console, it looks like we set up the bundle ID to have the Sign In with Apple capability there as well, not just locally in the project. That is probably needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure kind/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] How-To Sign in with Apple
6 participants