Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Binding that should be treated as regular property #18346

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Oct 1, 2024

GitHub Issue (If applicable): closes #18345

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18346/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18346/index.html

@github-actions github-actions bot added the area/code-generation Categorizes an issue or PR as relevant to code generation label Oct 1, 2024
@Youssef1313
Copy link
Member Author

This PR needs IsPropMethodCall to be completed. The reason this is needed is that now Control.TabNavigation bindings are broken, because we are declaring it this way:

image

This means, the DP registry doesn't really have a property with name TabNavigation. On WinUI, the property is actually registered, and is marked as IsPropMethodCall so that it can delegate to TabFocusNavigation.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18346/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18346/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code-generation Categorizes an issue or PR as relevant to code generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle cases where Binding markup extension is treated as "regular" property value
2 participants