fix!: Check thread access in SetValue #15925
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15925/index.html |
pedrojesus-work
approved these changes
Mar 18, 2024
|
@Youssef1313 can you take a look at the test failures? |
Youssef1313
force-pushed
the
issues/15879
branch
from
f46990e
to
3dd8d1f
Compare
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15925/index.html |
Youssef1313
commented
Sep 12, 2024
| [DataRow(false)] | ||
| public async Task Setting_Text_From_Background_Thread_Should_Fail(bool disableThreadingCheck) | ||
| { | ||
| var originalFlag = FeatureConfiguration.DependencyProperty.DisableThreadingCheck; |
There was a problem hiding this comment.
TODO: Make this part of the test conditional on WinUI as there is no such flag in WinUI
Youssef1313
commented
Sep 12, 2024
| @@ -495,6 +496,11 @@ void SetValueWithTrace(DependencyProperty property, object? value, DependencyPro | |||
|
|
|||
| private void InnerSetValue(DependencyProperty property, object? value, DependencyPropertyValuePrecedences precedence, DependencyPropertyDetails? propertyDetails, bool isPersistentResourceBinding) | |||
| { | |||
| if (!FeatureConfiguration.DependencyProperty.DisableThreadingCheck) | |||
| { | |||
| NativeDispatcher.CheckThreadAccess(); | |||
There was a problem hiding this comment.
TODO:
This is failing these tests:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #15879
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):