Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Honor RID when copying native VLC assets on Windows #15786

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix: Honor RID when copying native VLC assets on Windows #15786

wants to merge 3 commits into from

Conversation

ebariche
Copy link
Member

@ebariche ebariche commented Mar 7, 2024

PR Type

What kind of change does this PR introduce?

  • Bugfix

PR Checklist

Please check if your PR fulfills the following requirements:

@github-actions github-actions bot added the area/build Categorizes an issue or PR as relevant to build infrastructure label Mar 7, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15786/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15786/index.html

@nventive-devops
Copy link
Contributor

The build 115775 found UI Test snapshots differences: android-28-net7: 20, android-28-net7-Snap: 48, ios: 62, ios-Snap: 493, skia-gtk-screenshots: 22, skia-linux-screenshots: 640, skia-windows-screenshots: 826, wasm: 57, wasm-automated-net7.0-UWP-Default-automated: 35, wasm-automated-net7.0-UWP-RuntimeTests-0: 0, wasm-automated-net7.0-UWP-RuntimeTests-1: 0, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 0

Details

  • android-28-net7: 20 changed over 819

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Check_ListView_Swallows_Measure_after_scroll
    • DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
    • Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
    • FocusManager_GetFocusedElement_ComboBoxItem_Validation_FocusManager_-_GetFocusedElement_-_ComboBoxItem_-_2_-_After_Selection
    • FocusManager_GetFocusedElement_ComboBoxItem_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
    • FocusManager_FocusDirection_Previous_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection
    • FocusManager_GetFocusedElement_ComboBoxItem_Validation_FocusManager_-_GetFocusedElement_-_ComboBoxItem_-_1_-_Initial_State
    • ListView_ExpandableItem_ExpandMultipleItems_Expanded_State
    • UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • When_InScrollViewer_after_scroll
    • Check_ListView_Swallows_Measure_before_scroll
    • When_InListView_after_scroll
    • ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Expanded_State
    • When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
    • When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage

  • android-28-net7-Snap: 48 changed over 1051

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Brushes_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransform
    • AutoSuggestBox_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Reason_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Reason
    • Animations_DoubleAnimation_RenderTransformOrigin_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_RenderTransformOrigin
    • Border_Border_CornerRadius_Clipping_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Clipping
    • Brushes_ImageBrushWithCompositeTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithCompositeTransform
    • RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
    • Brushes_UITests_Windows_UI_Xaml_Media_GradientBrushTests_GradientsPage_UITests_Windows_UI_Xaml_Media_GradientBrushTests_GradientsPage
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_ProgressRingHeightTest_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_ProgressRingHeightTest
    • Animations_DoubleAnimation_opacity_final_state_UITests_Windows_UI_Xaml_Media_Animation_DoubleAnimation_FinalState_Opacity
    • Brushes_ImageBrushWithScaleTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithScaleTransform
    • Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
    • Border_Border_Simple_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple
    • Brushes_Rectangle_Uno_UI_Samples_UITests_ImageBrushTestControl_Rectangle
    • AutoSuggestBox_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_BasicAutoSuggestBox_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_BasicAutoSuggestBox
    • Brushes_ImageBrushWithLateSource_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithLateSource
    • Brushes_PathImageBrushfill_Uno_UI_Samples_UITests_ImageBrushTestControl_PathImageBrushfill
    • MediaPlayerElement_Using_flv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Flv_Extension
    • MediaPlayerElement_Using_mkv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mkv_Extension
    • MediaPlayerElement_Using_mov_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mov_Extension
    • Progress_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220

  • ios: 62 changed over 265

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ComboBoxTests_Disabled_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Disabled
    • ListView_ObservableCollection_Creation_Count_Scrolled1
    • Pivot_Non_PivotItemChange_Validation_UITests_Shared_Windows_UI_Xaml_Controls_Pivot_Pivot_CustomContent_Automated
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • When_Navigated_CommandBarDisplayCustomBackButtonIcon_NativeFrame_Source_set
    • ScrollViewer_Margin_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Margin
    • Change_Manipulation_Property_After_property_change
    • ComboBoxTests_Fullscreen_Popup_iOS_Opened
    • ScrollViewer_Margin_Centered_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Margin_Centered
    • ScrollViewer_WhenSync_RunNormalAndCompletesWithNonIntermediate_UITests_Shared_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_UpdatesMode
    • When_CustomContentAndLongTitle_TitleShouldNotOverlapBarButtons_OnNavigateBack_NativeFrame_UITests_Windows_UI_Xaml_Controls_CommandBar_LongTitle_CommandBar_Frame
    • When_CustomContent_CommandBarTitleShouldBeVisible_NativeFrame_UITests_Windows_UI_Xaml_Controls_CommandBar_CustomContent_CommandBar_Frame
    • ComboBoxTests_Fullscreen_Popup_iOS_Closed
    • ScrollViewer_Clipping_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Clipping
    • ScrollViewer_Content_Margin_After-Scrolled
    • ScrollViewer_Removed_And_Added_Initial
    • ScrollViewer_Removed_And_Added_Restored
    • When_Content_NotTemplateBound_UITests_Shared_Windows_UI_Xaml_Controls_ScrollViewerTests_Hosted_ScrollViewer
    • When_Content_TemplateBound_UITests_Shared_Windows_UI_Xaml_Controls_ScrollViewerTests_Hosted_ScrollViewer
    • Check_CornerRadius_Border_CornerRadius=5

  • ios-Snap: 493 changed over 1042

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Animations_DoubleAnimation_Opacity_TextBlock_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_Opacity_TextBlock
    • Animations_UITests_Shared_Windows_UI_Xaml_Media_Animation_SetTargetProperty_UITests_Shared_Windows_UI_Xaml_Media_Animation_SetTargetProperty
    • AutoSuggestBox_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion
    • Border_BorderBottomwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderBottomwithmargins
    • Border_Border_CornerRadius_with_Opacity_Uno_UI_Samples_UITests_BorderTestsControl_Border_CornerRadius_with_Opacity
    • Border_Border_Simple_with_Uniform_Thickness_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_with_Uniform_Thickness
    • Border_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_LinearGradientBrush_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_LinearGradientBrush
    • Brushes_ImageBrushAlignmentXY2_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY2
    • Brushes_PathImageBrushfill_Uno_UI_Samples_UITests_ImageBrushTestControl_PathImageBrushfill
    • Brushes_UITests_Windows_UI_Xaml_Media_GradientBrushTests_LinearGradientBrush_Change_Stops_UITests_Windows_UI_Xaml_Media_GradientBrushTests_LinearGradientBrush_Change_Stops
    • ContentControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParent
    • Default_UITests_Shared_Windows_UI_Xaml_Controls_Canvas_Canvas_ZIndex_UITests_Shared_Windows_UI_Xaml_Controls_Canvas_Canvas_ZIndex
    • Default_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Margin_On_Container_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Margin_On_Container
    • Default_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_ObservableCollection_Unused_Space_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_ObservableCollection_Unused_Space
    • Default_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_ProportionalPanel_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_ProportionalPanel
    • FlipView_FlipView_Images_UITests_Windows_UI_Xaml_Controls_FlipView_FlipView_Images
    • Flyouts_Flyout_Attached_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_Attached
    • Flyouts_Flyout_ButtonInContent_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_ButtonInContent
    • Flyouts_Flyout_Events_Uno_UI_Samples_Content_UITests_Flyout_Flyout_Events
    • FrameworkElement_UITests_Windows_UI_Xaml_FrameworkElementTests_FrameworkElement_Opacity_UITests_Windows_UI_Xaml_FrameworkElementTests_FrameworkElement_Opacity

  • skia-gtk-screenshots: 22 changed over 1114

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Microsoft.UI.Composition-CompositionMaskBrush.png
    • Progress-ProgressRingHeightTest.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • MUX-WinUIProgressRing_CustomSources.png
    • MUX-NavigationViewRS4Page.png
    • Image-Image_Formats.png
    • NavigationView-NavigationViewRS4Page.png
    • Progress-WinUIProgressRing_Features.png
    • ListView-ListViewSelectedItems.png
    • MediaPlayerElement-Mini player.png
    • MediaPlayerElement-Using .avi.png
    • Image-ImageSourceStream.png
    • MUX-WinUIProgressRingPage.png
    • Pickers-CalendarView_Theming.png
    • PipsPager-PipsPagerExamples.png
    • MediaPlayerElement-Using .mp3 (Audio only).png
    • WinUI-PipsPagerExamples.png
    • Progress-WindowsProgressRing_GH1220.png
    • Microsoft.UI.Composition-CompositionVisualSurface.png

  • skia-linux-screenshots: 640 changed over 1114

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Image-ImageSourceFileUri.png
    • Image-ImageSourceUrlMsAppDataScheme.png
    • ListView-DragDrop_ListView_Custom_States.png
    • ListView-HorizontalListViewGrouped.png
    • ListView-ListViewVariableHeightButton.png
    • ListView-ListViewVariableHeightComplexTemplate.png
    • ListView-ListViewVariableItemHeight.png
    • ListView-ListView_VirtualizePanelAdaptaterIdCache.png
    • ListView-ListView_Weird_Measure.png
    • ListView-ListView_WithScrollViewer.png
    • MUX-NavigationViewAnimationPage.png
    • MUX-NavigationViewBasicPage.png
    • MUX-NavigationViewBlankPage1.png
    • MUX-NavigationViewCompactPaneLengthTestPage.png
    • MUX-NavigationViewCustomThemeResourcesPage.png
    • MUX-NavigationViewIsPaneOpenPage.png
    • MUX-NavigationViewItemTemplatePage.png
    • MUX-NavigationViewMenuItemStretchPage.png
    • Geometry-LineSegment.png
    • Gesture Recognizer-Button_Inside_Border.png

  • skia-windows-screenshots: 826 changed over 1114

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Animations-ColorAnimation_Background.png
    • Application-Given_Application.png
    • AutoSuggestBox-AutoSuggestBox_Icons.png
    • Brushes-ImageBrush_Stretch_None.png
    • ComboBox-ComboBox_MaxDropdownHeight.png
    • ComboBox-ComboBox_NativePopup.png
    • CommandBar-CommandBar_Native_With_TextBox.png
    • ContentControl-ContentControl_WithPadding.png
    • ContentPresenter-ContentPresenter_Background.png
    • Flyouts-Flyout_TemplatedParent.png
    • FrameworkElement-FrameworkElement_Sizes.png
    • Grid-Grid_def_MinMaxValues.png
    • Grid-Grid_DynamicRowColumn.png
    • Grid-Grid_InsideStackPanel_InsideButton.png
    • Image-ImageSourceStream.png
    • Image-ImageSourceUrlMsAppDataScheme.png
    • Image-ImageSourceUrlMsAppxScheme.png
    • Image-ImageSourceUrlNoScheme.png
    • Info-InfoBarPage.png
    • ItemsControl-ItemsControl_AppendItem.png

  • wasm: 57 changed over 1047

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • initial_state
    • MUXControlsTestApp.NavigationViewStretchPage
    • SamplesApp.Samples.NavigationViewSample.NavigationViewSample
    • UITests.Shared.Windows_UI_Xaml_Controls.CommandBar.CommandBar_Xaml_Automated
    • UITests.Windows_UI_Xaml_Controls.ProgressRing.WindowsProgressRing_GH1220
    • MUXControlsTestApp.NavigationViewItemTemplatePage
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_SelectedItem
    • UITests.Windows_Media.MediaPlayerTests
    • MUXControlsTestApp.NavigationViewCompactPaneLengthTestPage
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewWithinScollViewer
    • Uno.UI.Samples.Content.UITests.GridTestsControl.Grid_with_MinWidth_MinHeight
    • MUXControlsTestApp.NavigationViewAnimationPage
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.HorizontalListViewGrouped
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRingPage
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_CustomSources
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Flv_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Minimal
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewLegacy
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewSelectedItems
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Inside_ListView

  • wasm-automated-net7.0-UWP-Default-automated: 35 changed over 1949

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Default_StrokeThickness_MyPolygon
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • DatePicker_Flyout_DatePicker_-_Flyout
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
    • Check_ListView_Swallows_Measure_after_scroll
    • MinMaxTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
    • TextBlock_TextBlock_Span_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Span
    • TextBlock_TextBlock_Style_Inheritance_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Style_Inheritance
    • TextBlock_TextBlock_TextTrimming_VerticalAlignment_Stretch_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_TextTrimming_VerticalAlignment_Stretch
    • TextBlock_TextBoxSizeChanging_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBoxSizeChanging
    • TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • TextBlock_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Special_Character_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Special_Character
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • TextBlock_TextBlock_Run_Inheritance_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Run_Inheritance

  • wasm-automated-net7.0-UWP-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net7.0-UWP-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net7.0-UWP-RuntimeTests-2: 0 changed over 1

  • wasm-automated-net7.0-WinUI-Benchmarks-automated: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-2: 0 changed over 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebariche @unodevops @nventive-devops