Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(XamlReader): Properly support TemplateBinding of attached properties #13943

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Oct 10, 2023

GitHub Issue (If applicable): closes #13517

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Copilot Summary

🤖 Generated by Copilot at c187ba5

This pull request fixes a bug in the XamlReader that caused attached properties to be parsed incorrectly in some cases. It also updates the XamlObjectBuilder and the test assertions to follow the Xaml standard for attached properties and TemplateBindings.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Youssef1313
Copy link
Member Author

CI keeps timing out even with restarts.

@Youssef1313
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jeromelaban jeromelaban merged commit 150557a into unoplatform:master Oct 12, 2023
86 checks passed
@Youssef1313 Youssef1313 deleted the issues/13517 branch October 12, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attached-property TemplateBinding parsed with XamlReader fails to provide value
3 participants