fix(ColorPicker): ToolTip of ColorPickerSlider doesn't work properly #13912
Conversation
github-actions
bot
added
the
area/automation
TopProgrammer77
changed the title
| // ToolTip doesn't currently provide any way to re-run its placement logic if its placement target moves, | ||
| // so toggling IsEnabled induces it to do that without incurring any visual glitches. | ||
| toolTip.IsEnabled = false; | ||
| toolTip.IsEnabled = true; |
There was a problem hiding this comment.
This code matches WinUI and shouldn't be changed. I believe @jeromelaban was already working on the proper fix.
There was a problem hiding this comment.
I fixed 2 issues( #13868 and #13865) in this PR. Which issue was @jeromelaban working on?
There was a problem hiding this comment.
@jeromelaban , @Youssef1313 .
No need to PR for issues #13868 and #13865?
There was a problem hiding this comment.
Indeed, we cannot change that code as the original behavior from winui needs to be kept and tooltip needs to get the behavior that ColorPickerSlider is depending on. I worked on this during last week's stream, see https://www.youtube.com/watch?v=8Txc13MMJQk, though I did not get to finish it.
There was a problem hiding this comment.
Thanks @jeromelaban. Are the any plans to finalize your work?
There was a problem hiding this comment.
@DierkDroth not at this time, but it can be reused to update this PR.
There was a problem hiding this comment.
Ah, thanks @jeromelaban for letting us know.
|
@jeromelaban @Youssef1313 Is there any chance to get this PR reviewed? I would be happy to test that fix as those issues manifest themselves in my UNO WASM app. Thanks in advance |
TopProgrammer77
force-pushed
the
ColorPicker
branch
from
2234ae9
to
a152988
Compare
|
@jeromelaban @Youssef1313 |
TopProgrammer77
force-pushed
the
ColorPicker
branch
from
a152988
to
1e44ad6
Compare
|
This PR isn't needed now because I can't reproduce the issue on the latest Uno. |
GitHub Issue (If applicable): closes #13868
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Copilot Summary
🤖 Generated by Copilot at 2234ae9
This pull request enhances the
ColorPickerandColorPickerSlidercontrols, fixes a bug with theSliderthumb tooltip, and adds a new UI test and a new sample page for theColorPicker. It also adds some null checks and flags to improve the stability and performance of theToolTipandSlidercontrols.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):