Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust corner-radius border rendering on Skia #10260

Merged
merged 6 commits into from
Oct 27, 2022
Merged

fix: Adjust corner-radius border rendering on Skia #10260

merged 6 commits into from
Oct 27, 2022

Conversation

MartinZikmund
Copy link
Member

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Borders on Skia did not render correctly

What is the new behavior?

Borders render correctly

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@gitpod-io
Copy link

gitpod-io bot commented Oct 26, 2022

@github-actions github-actions bot added the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label Oct 26, 2022
@nventive-devops
Copy link
Contributor

The build 59941 found UI Test snapshots differences: android-28-xamarin: 0, android-28-xamarin-Snap: 0, ios: 25, ios-Snap: 96, macOS-screenshots: 39, skia-gtk-screenshots: 121, skia-wpf-screenshots: 122, wasm: 32, wasm-automated-net7.0-Benchmarks: 0, wasm-automated-net7.0-Default: 8, wasm-automated-net7.0-RuntimeTests: 0

Details

  • android-28-xamarin: 0 changed over 0

  • android-28-xamarin-Snap: 0 changed over 0

  • ios: 25 changed over 296

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
    • ListView_ChangingText_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Changing_Text
    • ListView_ObservableCollection_Creation_Count_Added
    • ListView_ObservableCollection_Creation_Count_Added_above
    • ListView_ObservableCollection_Creation_Count_Removed_above
    • ListView_ObservableCollection_Creation_Count_Scrolled1
    • ListView_ObservableCollection_Creation_Count_Scrolled2
    • BasicExpressionTest_UITests_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBox_ExpressionTest
    • Keyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • Screenshots_Image_Stretch_Alignment_Equal_Mode-1
    • Screenshots_Image_Stretch_Alignment_Equal_Mode-2
    • Screenshots_Image_Stretch_Alignment_Equal_Mode-3
    • TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • TextBox_RoundedCorners_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_RoundedCorners

  • ios-Snap: 96 changed over 1002

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Animations_DoubleAnimation_TranslateX_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_TranslateX
    • Animations_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimation_Background_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimation_Background
    • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • Border_Border_Simple_with_Opacity_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_with_Opacity
    • Border_Uno_UI_Samples_UITests_BorderTestsControl_Border_BorderThickness_Uno_UI_Samples_UITests_BorderTestsControl_Border_BorderThickness
    • Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
    • Brushes_ImageBrushWithLateSource_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithLateSource
    • Brushes_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransform
    • Brushes_UITests_Windows_UI_Xaml_Media_BrushesTests_SolidColorBrush_Color_Changed_UITests_Windows_UI_Xaml_Media_BrushesTests_SolidColorBrush_Color_Changed
    • Brushes_UITests_Windows_UI_Xaml_Media_GradientBrushTests_LinearGradientBrush_Change_Stops_UITests_Windows_UI_Xaml_Media_GradientBrushTests_LinearGradientBrush_Change_Stops
    • Brushes_UITests_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_Formats_UITests_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_Formats
    • Buttons_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsBasicPage_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsBasicPage
    • CommandBar_CommandBar_Xaml_Automated_UITests_Shared_Windows_UI_Xaml_Controls_CommandBar_CommandBar_Xaml_Automated
    • ContentControl_ContentControl_WithPadding_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_WithPadding
    • Default_UITests_Shared_Windows_UI_Xaml_Controls_Canvas_Canvas_With_Outer_Clip_UITests_Shared_Windows_UI_Xaml_Controls_Canvas_Canvas_With_Outer_Clip
    • Default_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_ProportionalPanel_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_ProportionalPanel
    • ComboBox_ComboBox_NativePopup_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_NativePopup
    • ComboBox_ComboBox_Picker_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Picker
    • ContentControl_ContentControl_FindName_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_FindName
    • ContentControl_ContentControl_MultiLevelInheritance_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_MultiLevelInheritance

  • macOS-screenshots: 39 changed over 1075

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Animations-BeginTime_MultipleAnimations.png
    • ColorPicker-WinUIColorPickerPage.png
    • Buttons-SplitButtonPage.png
    • Gesture Recognizer-Pointer Events test bench.png
    • Grid-Grid_DataBound_ColumnRow_Definitions.png
    • Image-Image_Stretch_Alignment_SizeOnControl.png
    • Image-Image_Stretch_None_ScrollViewer.png
    • Info-InfoBarPage.png
    • ItemsRepeater-UniformGridLayout_Simple.png
    • Image-Image_Formats.png
    • ListView-ListView_With_ListViews_Count_Measure.png
    • ListView-ListView_Weird_Measure.png
    • MUX-NavigationViewRS3Page.png
    • MUX-NavigationViewRS4Page.png
    • MUX-NavigationViewSelectedItemEdgeCasePage.png
    • MUX-NavigationViewTopNavOnlyPage.png
    • MUX-NavigationViewTopNavPage.png
    • MediaPlayerElement-Using .avi.png
    • MediaPlayerElement-Using .mkv.png
    • MUX-InfoBarPage.png

  • skia-gtk-screenshots: 121 changed over 1067

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Border-Border_AntiAlias.png
    • Border-Border_Clipped_Change_Property.png
    • Border-Border_CornerRadius.png
    • Border-Border_CornerRadius_Alignments.png
    • Border-Border_CornerRadius_Binding.png
    • Border-Border_CornerRadius_BorderThickness.png
    • Border-Border_CornerRadius_Clipping.png
    • Border-Border_CornerRadius_Gradient.png
    • Border-Border_Corner_Overlap.png
    • Border-Border_LinearGradientBrush.png
    • Border-Circle.png
    • Border-NonUniformThicknessandRadius.png
    • Border-OnepxThicknessandRadius.png
    • Border-OnepxThicknessandRadiusAndTextBlock.png
    • Border-UniformThicknessandNonUniformRadius.png
    • Border-Uniform_Thickness_and_Large_Radius.png
    • Border-Uniform_Thickness_and_Small_Radius.png
    • BreadcrumbBar-BreadcrumbBarPage.png
    • Brushes-BorderImageBrush.png
    • Brushes-Ellipse.png

  • skia-wpf-screenshots: 122 changed over 1067

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Automation-AutomationProperties_Name.png
    • Border-Border_AntiAlias.png
    • Border-Border_CornerRadius_Alignments.png
    • Border-Border_CornerRadius_Binding.png
    • Border-Border_CornerRadius_Gradient.png
    • Border-Border_LinearGradientBrush.png
    • Border-UniformThicknessandNonUniformRadius.png
    • Border-Uniform_Thickness_and_Large_Radius.png
    • Brushes-BorderImageBrush.png
    • Brushes-GradientsPage.png
    • Brushes-ImageBrushAlignmentXY.png
    • Brushes-ImageBrush_StreamSource.png
    • Brushes-SolidColorBrush_Color_Changed.png
    • Border-Border_Clipped_Change_Property.png
    • Border-Border_CornerRadius.png
    • Border-Border_CornerRadius_BorderThickness.png
    • Border-Border_CornerRadius_Clipping.png
    • Border-Border_Corner_Overlap.png
    • Border-Circle.png
    • Border-NonUniformThicknessandRadius.png

  • wasm: 32 changed over 1010

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MUXControlsTestApp.NavigationViewMenuItemStretchPage
    • MUXControlsTestApp.NavigationViewPage
    • MUXControlsTestApp.NavigationViewTopNavPage
    • MUXControlsTestApp.PipsPagerPage
    • SamplesApp.Samples.Windows_UI_Xaml_Controls.NavigationViewTests.NavigationView_BasicNavigation
    • MUXControlsTestApp.NavigationViewAnimationPage
    • MUXControlsTestApp.NavigationViewRS4Page
    • MUXControlsTestApp.NavigationViewTopNavOnlyPage
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewHeaderImage
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewLargeHeader
    • UITests.Microsoft_UI_Xaml_Controls.ColorPickerTests.ColorPickerSample
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRingPage
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_CustomSources
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_Features
    • UITests.Microsoft_UI_Xaml_Controls.TabViewTests.TabViewPage
    • UITests.Shared.Microsoft_UI_Xaml_Controls.ColorPickerTests.WinUIColorPickerPage
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewVariableHeightComplexTemplate
    • UITests.Microsoft_UI_Xaml_Controls.NavigationViewTests.NavigationViewBasicPage
    • UITests.Shared.Windows_Devices.Midi.MidiDeviceEnumerationTests

  • wasm-automated-net7.0-Benchmarks: 0 changed over 1

  • wasm-automated-net7.0-Default: 8 changed over 882

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • ListView_Weird_Measure_During_Arrange_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Weird_Measure
    • MinMaxTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic
    • SubMenuTest_UITests_Shared_Microsoft_UI_Xaml_Controls_RadioMenuFlyoutItemTests_RadioMenuFlyoutItemPage
    • TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage

  • wasm-automated-net7.0-RuntimeTests: 0 changed over 1

@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Oct 27, 2022
@MartinZikmund MartinZikmund mentioned this pull request Oct 27, 2022
Open
@MartinZikmund MartinZikmund mentioned this pull request Oct 27, 2022
Closed
@nventive-devops
Copy link
Contributor

The build 60098 found UI Test snapshots differences: android-28-xamarin: 0, android-28-xamarin-Snap: 0, ios: 48, ios-Snap: 95, macOS-screenshots: 38, skia-gtk-screenshots: 118, skia-wpf-screenshots: 119, wasm: 32, wasm-automated-net7.0-Benchmarks: 0, wasm-automated-net7.0-Default: 11, wasm-automated-net7.0-RuntimeTests: 0

Details

  • android-28-xamarin: 0 changed over 0

  • android-28-xamarin-Snap: 0 changed over 0

  • ios: 48 changed over 296

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-0_0_0_0
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_0_0_10
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_10_10_10
    • Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
    • ListView_ObservableCollection_Creation_Count_Added
    • ListView_ObservableCollection_Creation_Count_Added_above
    • BasicExpressionTest_UITests_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBox_ExpressionTest
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_0_0_0
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_0_10_10
    • Border_CornerRadius_BorderThickness_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_BorderThickness
    • ContentPresenter_Template_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Template
    • DatePicker_Flyout_DatePicker_-_Flyout
    • Flyout_ShowAt_Window_Content_UITests_Windows_UI_Xaml_Controls_FlyoutTests_Flyout_ShowAt_Window_Content
    • Keyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
    • ListView_ObservableCollection_Creation_Count_Removed_above
    • ListView_ObservableCollection_Creation_Count_Scrolled1
    • ListView_ObservableCollection_Creation_Count_Scrolled2

  • ios-Snap: 95 changed over 1002

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • AutoSuggestBox_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_BitmapIcon_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_BitmapIcon
    • Border_AutoBorderStretchwithleftmargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithleftmargin
    • Border_Border_CornerRadius_BorderThickness_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_BorderThickness
    • Border_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Toggle_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Toggle
    • AutoSuggestBox_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Icons_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Icons
    • Border_AutoBorderStretchwithtopmargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithtopmargin
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_ButtonWithClippingAndOffset_SamplesApp_Windows_UI_Xaml_Clipping_ButtonWithClippingAndOffset
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_DoubleAnimationClipping_SamplesApp_Windows_UI_Xaml_Clipping_DoubleAnimationClipping
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_Transform_Ellipse_In_Border_SamplesApp_Windows_UI_Xaml_Clipping_Transform_Ellipse_In_Border
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_Transform_Ellipse_in_Canvas_SamplesApp_Windows_UI_Xaml_Clipping_Transform_Ellipse_in_Canvas
    • ComboBox_ComboBox_SelectedIndex_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_SelectedIndex
    • Default_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_ProportionalPanel_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_ProportionalPanel
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_ButtonClippingTestsControl_SamplesApp_Windows_UI_Xaml_Clipping_ButtonClippingTestsControl
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping
    • Clipping_UITests_Shared_Windows_UI_Xaml_Clipping_ClippingRoundedCorners_UITests_Shared_Windows_UI_Xaml_Clipping_ClippingRoundedCorners
    • Clipping_UITests_Shared_Windows_UI_Xaml_Clipping_ClippingToControlBounds_UITests_Shared_Windows_UI_Xaml_Clipping_ClippingToControlBounds
    • ComboBox_ComboBox_ItemsSource_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_ItemsSource
    • ComboBox_ComboBox_NativePopup_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_NativePopup
    • ComboBox_ComboBox_Picker_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Picker
    • Default_UITests_Shared_Windows_UI_Xaml_Controls_Popup_Popup_Overlay_On_UITests_Shared_Windows_UI_Xaml_Controls_Popup_Popup_Overlay_On

  • macOS-screenshots: 38 changed over 1075

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Border-Border_CornerRadius_BorderThickness.png
    • BreadcrumbBar-BreadcrumbBarPage.png
    • Brushes-DynamicBrushes_On_Shapes.png
    • Buttons-Custom_Button_With_ContentTemplate.png
    • ColorPicker-WinUIColorPickerPage.png
    • Gesture Recognizer-Pointer Events test bench.png
    • Image-Image_Fixed_Size_Alignment.png
    • Image-Image_Stretch.png
    • Image-Image_Stretch_Alignment_Smaller.png
    • Image-Image_Stretch_Alignment_Wider.png
    • Image-SvgImageSource_FromStream.png
    • Info-InfoBarPage.png
    • ListView-ListView_With_ListViews_Count_Measure.png
    • MUX-NavigationViewAnimationPage.png
    • MUX-NavigationViewPage.png
    • MUX-NavigationViewTopNavOnlyPage.png
    • MUX-NavigationViewTopNavPage.png
    • MediaPlayerElement-Using .flv.png
    • MediaPlayerElement-Using .mkv.png
    • MediaPlayerElement-Using .ogg.png

  • skia-gtk-screenshots: 118 changed over 1067

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Border-Border_AntiAlias.png
    • Border-Border_CornerRadius_Alignments.png
    • Border-Border_CornerRadius_Binding.png
    • Border-Border_CornerRadius_Gradient.png
    • Border-Border_LinearGradientBrush.png
    • Border-UniformThicknessandNonUniformRadius.png
    • Border-Uniform_Thickness_and_Large_Radius.png
    • Brushes-BorderImageBrush.png
    • Brushes-GradientsPage.png
    • Brushes-ImageBrushAlignmentXY.png
    • Brushes-ImageBrush_StreamSource.png
    • Buttons-DropDownButtonPage.png
    • Border-Border_Clipped_Change_Property.png
    • Border-Border_CornerRadius.png
    • Border-Border_CornerRadius_BorderThickness.png
    • Border-Border_CornerRadius_Clipping.png
    • Border-Circle.png
    • Border-NonUniformThicknessandRadius.png
    • Border-OnepxThicknessandRadius.png
    • Border-OnepxThicknessandRadiusAndTextBlock.png

  • skia-wpf-screenshots: 119 changed over 1067

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Border-Border_Clipped_Change_Property.png
    • Border-Border_CornerRadius.png
    • Border-Border_CornerRadius_BorderThickness.png
    • Border-Border_CornerRadius_Clipping.png
    • Border-Circle.png
    • Border-NonUniformThicknessandRadius.png
    • Border-OnepxThicknessandRadius.png
    • Border-OnepxThicknessandRadiusAndTextBlock.png
    • Border-Uniform_Thickness_and_Small_Radius.png
    • BreadcrumbBar-BreadcrumbBarPage.png
    • Brushes-Ellipse.png
    • Brushes-ImageBrushChangingCornerRadius.png
    • Brushes-ImageBrushLocalAsset.png
    • Brushes-ImageBrushStretch.png
    • Brushes-PanelImageBrush.png
    • Brushes-SolidColorBrush_Color_Changed.png
    • Border-Border_AntiAlias.png
    • Border-Border_CornerRadius_Alignments.png
    • Border-Border_CornerRadius_Binding.png
    • Border-Border_CornerRadius_Gradient.png

  • wasm: 32 changed over 1010

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MUXControlsTestApp.NavigationViewAnimationPage
    • MUXControlsTestApp.NavigationViewBlankPage1
    • MUXControlsTestApp.NavigationViewPage
    • MUXControlsTestApp.NavigationViewRS4Page
    • MUXControlsTestApp.NavigationViewStretchPage
    • SamplesApp.Samples.Windows_UI_Xaml_Controls.NavigationViewTests.NavigationView_Pane_Automated
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewChangeView
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewContainerFromItem
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewHeaderImage
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewLargeHeader
    • SamplesApp.Windows_UI_Xaml_Shapes.StretchPage
    • UITests.Microsoft_UI_Xaml_Controls.ColorPickerTests.ColorPickerSample
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRingPage
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_CustomSources
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_Features
    • UITests.Microsoft_UI_Xaml_Controls.RatingControlTests.RatingControlPage
    • UITests.Shared.Windows_Devices.Midi.MidiDeviceEnumerationTests
    • UITests.Shared.Windows_UI_Xaml_Automation.AutomationProperties_Name
    • UITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_MaxDropdownHeight

  • wasm-automated-net7.0-Benchmarks: 0 changed over 1

  • wasm-automated-net7.0-Default: 11 changed over 882

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-0_0_0_0
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_0_0_0
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_10_10_10
    • Border_CornerRadius_BorderThickness_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_BorderThickness
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_0_0_10
    • Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_0_10_10
    • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • ListView_Weird_Measure_During_Arrange_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Weird_Measure
    • TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • Validate_Offscreen_Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes
    • When_TransformToVisual_ScrollViewer_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_ScrollViewer

  • wasm-automated-net7.0-RuntimeTests: 0 changed over 1

@MartinZikmund MartinZikmund merged commit 3892120 into master Oct 27, 2022
@MartinZikmund MartinZikmund deleted the dev/mazi/border-adjust branch October 27, 2022 21:37
@MartinZikmund MartinZikmund added the hacktoberfest-accepted Accepted Hacktoberfest contribution! label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot approved these changes

@jeromelaban jeromelaban Awaiting requested review from jeromelaban

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia hacktoberfest-accepted Accepted Hacktoberfest contribution!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinZikmund @nventive-devops @spouliot @jeromelaban