perf: Use memoized FindType instead of SourceFindType

unoplatform · May 9, 2023 · 743c1f8 · 743c1f8
1 parent 69095eb
commit 743c1f8
Showing 1 changed file with 8 additions and 12 deletions.
diff --git a/src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs b/src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs
@@ -5457,7 +5457,7 @@ private string RewriteAttachedPropertyPath(string value)
 
 							if (parts.Length == 2)
 							{
-								var targetType = SourceFindType(parts[0]);
+								var targetType = FindType(parts[0]);
 
 								if (targetType != null)
 								{
@@ -5912,25 +5912,21 @@ private void BuildChild(IIndentedStringBuilder writer, XamlMemberDefinition? own
 					}
 					else if (target != null)
 					{
-						// This builds property setters for specified member setter.
-						var separatorIndex = target.IndexOf(".", StringComparison.Ordinal);
-						var elementName = target.Substring(0, separatorIndex);
-						var propertyName = target.Substring(separatorIndex + 1);
-
 						var ownerControl = GetControlOwner(owner?.Owner);
 
-
-						// Attached properties need to be expanded using the namespace, otherwise the resolution will be
-						// performed at runtime at a higher cost.
-						propertyName = RewriteAttachedPropertyPath(propertyName);
-
 						if (ownerControl != null)
 						{
-
+							// This builds property setters for specified member setter.
+							var separatorIndex = target.IndexOf(".", StringComparison.Ordinal);
+							var elementName = target.Substring(0, separatorIndex);
 							var targetElement = FindSubElementByName(ownerControl, elementName);
 
 							if (targetElement != null)
 							{
+								var propertyName = target.Substring(separatorIndex + 1);
+								// Attached properties need to be expanded using the namespace, otherwise the resolution will be
+								// performed at runtime at a higher cost.
+								propertyName = RewriteAttachedPropertyPath(propertyName);
 								writer.AppendLineIndented($"new global::Windows.UI.Xaml.Setter(new global::Windows.UI.Xaml.TargetPropertyPath(this._{elementName}Subject, \"{propertyName}\"), ");
 
 								var targetElementType = GetType(targetElement.Type);