fix(macOS): Enable the linker/trimmer for net6.0-macos #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dope's Xamarin.Mac legacy project already has this setting. In order to compare apples-to-apples it's best to share the same settings between Xamarin.Mac legacy and net6.0-macos. Enabling the linker/trimmer does more than just removing unused code. It also optimize the bindings, removing code paths that are not used inside the app, e.g. removing 32bits code paths on 64bits builds. It's a good, performance enhancing, setting for release builds so it make sense to have it set inside samples - leading by example :) ref: unoplatform/uno#8890 (comment)
jeromelaban
approved these changes
Jun 7, 2022
|
Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue. |
jeromelaban
added a commit
to unoplatform/uno
that referenced
this pull request
Jun 7, 2022
This change is based on unoplatform/performance#13
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #
None specific but it was mentioned in unoplatform/uno#8890 (comment)
PR Type
What is the current behavior?
The Dope's Xamarin.Mac legacy project already has this setting enabled.
However the
net6.0-macosproject does not set it.In order to compare apples-to-apples it's best to share the same
settings between Xamarin.Mac legacy and net6.0-macos.
What is the new behavior?
Both projects have the linker/trimmer enabled in release mode.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Enabling the linker/trimmer does more than just removing unused code.
It also optimize the bindings, removing code paths that are not used
inside the app, e.g. removing 32bits code paths on 64bits builds.
It's a good, performance enhancing, setting for release builds so it
make sense to have it set inside samples - leading by example :)