Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[on hold till next version] Port getOwnersByPage to an extension #6143

Closed
wants to merge 1 commit into from

Conversation

HardlyDifficult
Copy link
Contributor

Description

Creates a LockInspector extension contract. I started with just getOwnersByPage but there may be other functions to port over - or just to add for convenience.

A small simplification to the lock contract and saves us a bit of space.

The tests are basically what we had previously, but I also removed the revert for this read-only call.

Issues

Fixes #
Refs #6010

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@HardlyDifficult HardlyDifficult added the smart contract Smart contract related issue or task label Mar 4, 2020
@HardlyDifficult HardlyDifficult requested a review from nfurfaro March 4, 2020 07:43
@cla-bot cla-bot bot added the cla-signed label Mar 4, 2020
@HardlyDifficult
Copy link
Contributor Author

Reduces PublicLock deployment by 90.5k gas. I'm unsure how much that is in terms of our byte limit.

Copy link
Contributor

@nfurfaro nfurfaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We could possibly add the utils functions in UnlockUtils.sol (only used for metadata) as well.

@HardlyDifficult
Copy link
Contributor Author

UnlockUtils.sol

That's an internal library atm. But the general point of should this be in smart-contracts or smart-contract-extensions is a good question. I'm torn on it.

Additionally maybe we do not merge this until after v7. We don't have a deploy process figured for extensions yet..

@nfurfaro
Copy link
Contributor

nfurfaro commented Mar 4, 2020

I think we should wait to merge till after v7.

@HardlyDifficult HardlyDifficult changed the title Port getOwnersByPage to an extension [on hold till next version] Port getOwnersByPage to an extension Mar 4, 2020
@julien51 julien51 deleted the hardlydifficult/lockInspector branch November 20, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed smart contract Smart contract related issue or task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants