-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Migrate to react
19
#15358
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment. it looks like we change the return type when we go from => ()
(returns whatever is in ()
) to => {}
(requires an explicit return
or it would return undefined
)
Thx!
absolutely, good catch! |
Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com>
"@headlessui/react": "^2.2.0", | ||
"react": "^19.0.0", | ||
"react-dom": "^19.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's pin the deps please!
@@ -264,7 +264,7 @@ export const RegistrationForm = ({ | |||
await onRSVP({ | |||
recipient, | |||
data, | |||
captcha, | |||
captcha: captcha || '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hum, please let's not do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain please?
@@ -78,7 +78,7 @@ export function ConfirmClaim({ checkoutService, onConfirmed, onError }: Props) { | |||
const captcha = await recaptchaRef.current?.executeAsync() | |||
const { hash } = await claim({ | |||
data: purchaseData?.[0], | |||
captcha, | |||
captcha: captcha || '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let;s replace the captcha dep first.. and THEN update react so we don't have too many things!
Same with the blog post linting!
Description
This PR introduces an upgrade of the
unlock
monorepo toreact
v19.Issues
Fixes #
Refs #15356
Checklist: