Fix to chce_wireguard.sh wireguard's port being set to 200#231
Open
KarolAdameczek wants to merge 2 commits intounkn0w:mainfrom
Open
Fix to chce_wireguard.sh wireguard's port being set to 200#231KarolAdameczek wants to merge 2 commits intounkn0w:mainfrom
KarolAdameczek wants to merge 2 commits intounkn0w:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"https://mikr.us/generator.php" expects server name in old format (e.g. j123) instead of current format (e.g. julia123). When name in new format (e.g. julia123) is provided, then returned config has port set to 200 (instead of correct 20123 for this sample host). Adding this sed to extract first letter and tailing number from hostname and combining them fixes this issue.
One question that came to my mind is if generator endpoint should be used at all? Maybe it should be abandoned in favour of creating config file directly in the script.
If there is a better way to implement this, please let me know. I'm no shell master and that's my first github contribution. :)