Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollup)!: default to esnext build target #335

Merged
merged 1 commit into from
Nov 6, 2023
Merged

feat(rollup)!: default to esnext build target #335

merged 1 commit into from
Nov 6, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/module-builder#181 (comment)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Not quite sure how to categorise, but this bumps esbuild target from es2020 to esnext. However, we might consider using a year-bound target (https://esbuild.github.io/content-types/#javascript) to fix the feature-set.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 November 6, 2023 11:06
@danielroe danielroe self-assigned this Nov 6, 2023
@pi0 pi0 changed the title fix: default to esnext build target feat(rollup)!: default to esnext build target Nov 6, 2023
@pi0
Copy link
Member

pi0 commented Nov 6, 2023

This seems a fine default behavior to me to not modify used syntaxes unless configured to do as syntaxes like import assertion which not only are supported in Node.js/v8 but are also essential(!) do not get stripped.

@pi0 pi0 merged commit a006769 into main Nov 6, 2023
2 checks passed
@pi0 pi0 deleted the fix/esnext branch November 6, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants