Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use jiti.import for esm stubs and improve templates #300

Merged
merged 9 commits into from
Oct 30, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Aug 16, 2023

requires unjs/jiti#158

@pi0
Copy link
Member

pi0 commented Aug 16, 2023

(drafting until we support jiti.import)

@varugasu

This comment was marked as off-topic.

@pi0

This comment was marked as off-topic.

@varugasu

This comment was marked as off-topic.

@pi0

This comment was marked as off-topic.

@varugasu

This comment was marked as off-topic.

@pi0

This comment was marked as off-topic.

@pi0 pi0 changed the title feat: allow esm jiti stub refactor: jiti.import for esm stubs Oct 30, 2023
@pi0 pi0 changed the title refactor: jiti.import for esm stubs refactor: use jiti.import for esm stubs and improve templates Oct 30, 2023
@pi0 pi0 marked this pull request as ready for review October 30, 2023 17:56
@pi0
Copy link
Member

pi0 commented Oct 30, 2023

Updated implementation to allow iterating. From what i extracted for now and need to do in next steps

  • We need to resolve jiti's esm entry path for esm (and avoid windows path to url normalization for vite support?)
  • We need to pass native _import implementation to jiti.import

@pi0 pi0 merged commit 974caff into main Oct 30, 2023
2 checks passed
@pi0 pi0 deleted the feat/jiti-esm branch October 30, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants