Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support alias and esbuild config #29

Merged
merged 5 commits into from
Dec 10, 2021
Merged

feat: support alias and esbuild config #29

merged 5 commits into from
Dec 10, 2021

Conversation

hannoeru
Copy link
Contributor

@hannoeru hannoeru commented Dec 8, 2021

No description provided.

@pi0
Copy link
Member

pi0 commented Dec 10, 2021

Thanks for PR @hannoeru! I've made two slight modifications before merging:

  • alias is now an object in order to reuse for other builders in the future and simplicity
  • esbuild moved to rollup.esbuild

@hannoeru
Copy link
Contributor Author

@pi0 can we also support resolve .tsx & .jsx extensions?

@pi0
Copy link
Member

pi0 commented Dec 10, 2021

@hannoeru Sure! Would you mind opening a future request issue?

@pi0 pi0 merged commit b0b09e0 into unjs:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannoeru @pi0