Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rollup): check module id against externals as well #270

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix(rollup): check module id against externals as well #270

merged 1 commit into from
Jul 18, 2023

Conversation

yfwz100
Copy link
Contributor

@yfwz100 yfwz100 commented May 31, 2023 •
edited
Loading

With this change, it allows to externalize a specific module path like internal modules.

Fixes #269.

@yfwz100
feat: support externalize module path.
1a01bbc 
With this change, it allows to externalize a specific module path like internal modules.
@yfwz100 yfwz100 closed this May 31, 2023
@yfwz100 yfwz100 reopened this May 31, 2023
@pi0 pi0 changed the title feat: support externalize module path. fix(rollup): check module id against externals as well Jul 18, 2023
pi0
pi0 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit a4296b8 into unjs:main Jul 18, 2023
@pi0 pi0 mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support externalizing internal files
2 participants
@yfwz100 @pi0