Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup): handle array format for rollup.alias.entries option #220

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

zoeyzhao19
Copy link
Contributor

@zoeyzhao19 zoeyzhao19 commented Feb 21, 2023

rollop alias option from config file like

rollup: {
  alias: {
      entries: [
        {
          find: '@shared/types',
          replacement: path.resolve(projectRootDir, 'src/shared/types'),
        },
      ],
    }
}

entries above wouldn't get the right alias config since unbuild does not handle this scene.
This PR is related to #221

@pi0 pi0 changed the title fix: handle array format of rollup alias option fix(rollup): handle array format for alias.entries option Mar 27, 2023
@pi0 pi0 changed the title fix(rollup): handle array format for alias.entries option fix(rollup): handle array format for rollup.alias.entries option Mar 27, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 1b3dcbb into unjs:main Mar 27, 2023
@zoeyzhao19 zoeyzhao19 deleted the fix/enhance-option-alias branch April 16, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants