Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect directory separator when matching entries #214

Merged
merged 4 commits into from
Apr 15, 2023
Merged

fix: respect directory separator when matching entries #214

merged 4 commits into from
Apr 15, 2023

Conversation

Bernankez
Copy link
Contributor

fix #213

@Bernankez
Copy link
Contributor Author

I'm not sure if it's the right way to fix it.

@pi0 pi0 requested a review from danielroe March 27, 2023 10:29
danielroe
danielroe reviewed Mar 28, 2023
View reviewed changes
src/auto.ts Outdated Show resolved Hide resolved
danielroe
danielroe reviewed Mar 28, 2023
View reviewed changes
src/auto.ts Outdated Show resolved Hide resolved
danielroe
danielroe reviewed Mar 28, 2023
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot! ❤️ I think we likely also want to include files not prefixed with / (in case they are at root level), but that is a minor change.

pi0 and others added 2 commits March 28, 2023 11:16
@pi0 @danielroe
Update src/auto.ts
878a396 
Co-authored-by: Daniel Roe <daniel@roe.dev>
@pi0 @danielroe
Update src/auto.ts
65c4cb8 
Co-authored-by: Daniel Roe <daniel@roe.dev>
@pi0 pi0 requested a review from danielroe March 28, 2023 09:16
@danielroe danielroe changed the title fix: match similar files when inferring entry (#213) fix: respect directory separator when matching entries Apr 15, 2023
@danielroe danielroe merged commit 5df5058 into unjs:main Apr 15, 2023
@pi0 pi0 mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect inferred entries from package.json
3 participants
@Bernankez @danielroe @pi0