Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable strict typescript checks #200

Merged
merged 1 commit into from
Jan 13, 2025
Merged

chore: enable strict typescript checks #200

merged 1 commit into from
Jan 13, 2025

Conversation

43081j
Copy link
Member

@43081j 43081j commented Jan 9, 2025

Enables most of what's in the unjs tsconfig template, plus the following:

  • noUnusedLocals
  • noUnusedParameters

i didn't take the entire unjs template because it'd mean changing the module/moduleResolution/moduleDetection

@pi0 almost all of the casts are because noUncheckedIndexedAccess is true. we can turn it off if you think we will do that quite often (e.g. when we check length of something, we know it then has [0] but typescript doesn't)

Enables most of what's in the unjs tsconfig template, plus `noUnusedLocals.`
@43081j 43081j force-pushed the strict-ts-for-real branch from 9be6785 to a107680 Compare January 13, 2025 08:51
@pi0
Copy link
Member

pi0 commented Jan 13, 2025

Thanks for your time on this. noUnusedLocals/noUnusedParameters are covered by eslint rules already btw and I agree noUncheckedIndexedAccess is sometimes little annoying with ts. Seems all good to me for now.

@pi0 pi0 merged commit 871ce83 into main Jan 13, 2025
1 check passed
@pi0 pi0 deleted the strict-ts-for-real branch January 13, 2025 18:44
@pi0 pi0 changed the title chore: enable strict typescript compilation chore: enable strict typescript checks Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants