fix(format): allow calls with partial arguments #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
im going to split the changes into two PRs since i didn't notice the tests have many strict errors |
pi0
changed the title
In node, the following are valid calls of `format`:
```ts
format({ file: 'foo' });
// foo
format({ dir: '/foo', name: 'bar' });
// /foo/bar
format({ dir: '/foo', ext: 'bar' });
// /foo/.bar
```
The last one is a little nonsensical, but the other two are valid
(extensionless files for example). We should also be matching node's
behaviour of course.
Also enables `strict: true` in TypeScript, which is what caught this.
|
here you go i've dropped the typescript changes for now 👍 |
pi0
approved these changes
Jan 9, 2025
|
@43081j are you going to work on strict type fixes? (here is unjs new tsconfig for reference to adopt) |
ill take a look 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In node, the following are valid calls of
format:The last one is a little nonsensical, but the other two are valid (extensionless files for example). We should also be matching node's behaviour of course.
@pi0 this was actually a PR to enable strict mode in typescript, that then uncovered the bug. Let me know if you want me to chop the PR up into two PRs as this also adds some casts to make the compiler happy