-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass appropriate workspace args and improve tests #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this helps to better debug failed errors
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 98.07% 96.63% -1.44%
==========================================
Files 5 5
Lines 415 416 +1
Branches 66 60 -6
==========================================
- Hits 407 402 -5
- Misses 8 14 +6
|
pi0
changed the title
fix: pass approperiate workspace args
fix: pass approperiate workspace args and improve tests
Aug 29, 2023
pi0
changed the title
fix: pass approperiate workspace args and improve tests
fix: pass appropriate workspace args and improve tests
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Reported from nuxt/cli#116
β Type of change
π Description
I had missed this from big PR in #75
We were only testing installations in workspace mode (and still passing wrong arguments!)
This PR, first splits tests and adds both workspace and non workspace fixtures and tests, completely separated.
Also adds support for
workspace?: string|boolean
. Whentrue
or""
is passed, we assume installing into the workspace root. The string value when nonempty, is the workspace package name (in class of yarn classic, dir!)π Checklist