Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass appropriate workspace args and improve tests #90

Merged
merged 16 commits into from
Aug 29, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 29, 2023

πŸ”— Linked issue

Reported from nuxt/cli#116

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I had missed this from big PR in #75

We were only testing installations in workspace mode (and still passing wrong arguments!)

This PR, first splits tests and adds both workspace and non workspace fixtures and tests, completely separated.

Also adds support for workspace?: string|boolean. When true or "" is passed, we assume installing into the workspace root. The string value when nonempty, is the workspace package name (in class of yarn classic, dir!)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 marked this pull request as draft August 29, 2023 19:59
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #90 (61928fa) into main (84357e0) will decrease coverage by 1.44%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   98.07%   96.63%   -1.44%     
==========================================
  Files           5        5              
  Lines         415      416       +1     
  Branches       66       60       -6     
==========================================
- Hits          407      402       -5     
- Misses          8       14       +6     
Files Changed Coverage Ξ”
src/_utils.ts 94.77% <100.00%> (-3.73%) ⬇️
src/types.ts 100.00% <100.00%> (ΓΈ)

... and 1 file with indirect coverage changes

@pi0 pi0 changed the title fix: pass approperiate workspace args fix: pass approperiate workspace args and improve tests Aug 29, 2023
@pi0 pi0 changed the title fix: pass approperiate workspace args and improve tests fix: pass appropriate workspace args and improve tests Aug 29, 2023
@pi0 pi0 marked this pull request as ready for review August 29, 2023 21:31
@pi0 pi0 merged commit d480f6f into main Aug 29, 2023
5 of 6 checks passed
@pi0 pi0 deleted the fix/workspace branch August 29, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant