feat: add fullTraceInclude option
#4
+48
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipstersmoothie
commented
Oct 6, 2025
Comment on lines
+120
to
+130
|
|
||
| if (opts.fullTraceInclude) { | ||
| const allFiles = await glob("**/*", { | ||
| cwd: tracedFile.pkgPath, | ||
| ignore: ["node_modules/**"], | ||
| }); | ||
|
|
||
| for (const file of allFiles) { | ||
| tracedPackageVersion.files.push(file); | ||
| } | ||
| } |
There was a problem hiding this comment.
Currently this only adds all the files from a package detected by NFT. This does not account for new files discovered by nft. Not sure how to approach that
There was a problem hiding this comment.
With option bein array, we can pre-resolve them here
pi0
reviewed
Oct 6, 2025
| }; | ||
| tracedPackage.versions[pkgJSON.version || "0.0.0"] = tracedPackageVersion; | ||
|
|
||
| if (opts.fullTraceInclude) { |
There was a problem hiding this comment.
This option could be more granular by giving an array of problematic packages to full trace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nitrojs/nitro#1988