-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make TransformOptions
type strict to allow auto-complete
#305
Conversation
TransformOptions
type to not sacrifice auto-completionTransformOptions
type to not sacrifice auto-completion
Can you please elaborate where we loose auto complete? |
Sure, currently if we have something like this: createJiti(__filename, { transformOptions: { } }) When we type inside |
dd26181
to
7c4c7fc
Compare
Intresting seems it breaks |
In what way? |
Actually this line is the problem. not sure why we had it before but removing has same effort (yet we can keep extendable interface consistent with other current types) |
Yeah, that's why I removed that line, it was there before, not sure why. Does it look okay the way it is now? Or do you want me to make some other changes to it? |
I think removing that line should only be enough as it was tested locally so we can keep the interface mainly for consistency. |
I get: |
7c4c7fc
to
3d5444b
Compare
TransformOptions
type to not sacrifice auto-completionTransformOptions
type strict to allow auto-complete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR:
TransformOptions
type to not sacrifice auto-completion.