-
Notifications
You must be signed in to change notification settings - Fork 67
feat: lookup Github username if token is available #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I have no idea why the test is failing; it works here. Is the ungh API not available in CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work β€οΈ
@pi0 all set! |
@pi0 any chance of getting this merged? |
Hey! I believe this change would be very valuable and Iβd really like to see it implemented. Let me know if thereβs anything I can do to help! |
@marlondecol @pi0 I've created a follow up PR which will resolve the username from the PR which is referenced in the commit references. This will also find the correct username of the users who don't have a public email address in github: #294 |
π Linked issue
#116
β Type of change
π Description
Using @antfu's changelogithub as inspiration, I added this feature to changelogen.
If a GitHub token is available, it will retrieve usernames through the GitHub API. Otherwise, it returns the exact same author info as before.
Added tests with both a token and without a token.
Resolves #116
π Checklist