Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript,HTML: skip JSX elements #4191

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

masatake
Copy link
Member

This may fix the issue reported at
https://stackoverflow.com/questions/79395369/why-does-universal-ctags-fail-to-record-some-functions-in-the-tags-file-for-a-pr

TODO:

  • add more test cases
  • extract objects in JavaScript area in HTML area in JavaScript area

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 95.76271% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.94%. Comparing base (263749e) to head (6c6799a).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
parsers/jscript.c 91.07% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4191      +/-   ##
==========================================
+ Coverage   85.93%   85.94%   +0.01%     
==========================================
  Files         241      241              
  Lines       59187    59274      +87     
==========================================
+ Hits        50861    50944      +83     
- Misses       8326     8330       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masatake
Copy link
Member Author

@jafl Thank you for reviewing.
I will polish my change and add comments to the code before merging.

@masatake
Copy link
Member Author

We should merge #4193 first.

@masatake masatake force-pushed the jsx branch 2 times, most recently from 28b3adc to b890736 Compare February 17, 2025 10:12
@masatake masatake merged commit f272e5c into universal-ctags:master Feb 24, 2025
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants