Skip to content

Remove creds logs #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 1, 2025
Merged

Remove creds logs #430

merged 11 commits into from
Jul 1, 2025

Conversation

grallewellyn
Copy link
Contributor

Purpose

Credentials for dockerhub and dockstore are no longer printed in the logs upon an error or printed in the details section when running the DAG
This is because we switched to using kubernetes secrets to manage these credentials

Proposed Changes

  • [CHANGE] Dockerhub and dockstore credentials now handled with kubernetes secrets

Issues

unity-sds/unity-project-management#228
#398

Testing

  • tested that passing an invalid github url doesn't result in errors with credentials being printed to the logs
  • tested that passing a valid github url that is to a blank repo doesn't result in errors with credentials being printed to the logs
  • tested that this successfully uploads to dockerhub and dockstore with the right credentials
  • I can run this DAG successfully in my SPS deployment with the git url as https://github.com/unity-sds/unity-example-application

@grallewellyn grallewellyn requested a review from LucaCinquini July 1, 2025 00:01
Copy link
Collaborator

@LucaCinquini LucaCinquini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested deployment and execution, it works great.
I am also glad that we now have a working example on using the Kubernetes secrets within SPS and a DAG.

@LucaCinquini LucaCinquini merged commit 5ac95d7 into develop Jul 1, 2025
2 checks passed
@LucaCinquini LucaCinquini deleted the remove-creds-logs branch July 1, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants