-
Notifications
You must be signed in to change notification settings - Fork 4
307 - Modular DAG log levels #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@LucaCinquini - I think I covered all the changes that we discussed so I am going to set this PR as ready for review. Changes made to log levels:
Pending items:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikki-t : PR looks good, it's approved. BTW for now we are not using "SpsKubernetesPodOperator" any more because there is no need to override any functionality from "KubernetesPodOperator".
Purpose
The modular DAG stage in and stage out tasks generate logs that are too verbose.
Pending consideration:
I modified the existing stage in/out CWL to define a
log_level
input and have hosted those files here: stage_in and stage_outWe may want to request U-DS define the
LOG_LEVEL
environment variable as an input to theirstage-in.cwl
task if we want to continue to use their CWL definitions.Proposed Changes
log_level
input.-l
) argument and modify stage in/out commands to include a log level.set -x
command and passes the--debug
argument tocwltool
commands.Issues
Testing
Ran in
unity-venue-dev
onunity-nikki-1
deployment.