Skip to content

Removing rewrite calls from default mgmt config #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

jpl-btlunsfo
Copy link
Contributor

@jpl-btlunsfo jpl-btlunsfo commented Jul 14, 2024

Purpose

  • Switching the management ui configuration to a solely proxypass-based configuration, removing possibly disruptive rewrite calls
  • Adding some extra newline guards to the ssm-to-httpd-config process, so as to prevent httpd startup errors.

Proposed Changes

  • CHANGE the managementproxy_config ssm-parameter contents to use upgrade=websocket (per docs) on its proxypass calls, rather than leaving an unguarded rewritecond/rewriterule section
  • ADD force-inserted newlines after each fetched SSM parameter (as httpd config complains if two directives are on the same line)
  • UPDATE the readme snippets

Issues

  • no related open issues

Testing

@jpl-btlunsfo jpl-btlunsfo self-assigned this Jul 14, 2024
@jpl-btlunsfo jpl-btlunsfo requested a review from galenatjpl July 16, 2024 19:12
Copy link
Collaborator

@galenatjpl galenatjpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jpl-btlunsfo jpl-btlunsfo merged commit 7940f0b into main Jul 16, 2024
1 check passed
@jpl-btlunsfo jpl-btlunsfo deleted the btlunsfo-websocket-no-rewrite branch July 16, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants