Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Catalog & Collection Endpoint + items link #333

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

wphyojpl
Copy link
Collaborator

@wphyojpl wphyojpl commented Feb 23, 2024

Closes #331
Closes #332

@wphyojpl wphyojpl changed the title feat: add collections items link breaking: add collections items link Feb 26, 2024
@wphyojpl
Copy link
Collaborator Author

catalog.json
collection.json
feature.collection.json

sample results from updated logic, but replaced URLs with local URL for testing.
catalog_view
collection_view
granule_view

@wphyojpl
Copy link
Collaborator Author

There is no pagination link at this moment as limit = 50 pagination comes from Cumulus.
In the new logic, it is not hitting Cumulus till every collection is queried.
Only UDS Elasticsearch which has code to query all collections.

Of course, there is a chance it will break down when there are 100k or more collections.
But I'm not sure if we should add pagination at this moment.

@ngachung FYI.

@wphyojpl wphyojpl changed the title breaking: add collections items link breaking: Catalog & Collection Endpoint + items link Feb 26, 2024
@ngachung ngachung self-requested a review February 29, 2024 18:56
@ngachung ngachung merged commit 37bccf3 into develop Feb 29, 2024
1 check passed
@wphyojpl wphyojpl deleted the stac-browser-logic branch February 29, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants