Skip to content

fix: GitHub action write protected branch 15 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Oct 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
a0c2d1b
chore: dummy commit
wphyojpl Oct 2, 2023
a1ab3a5
Merge branch 'develop-2023-10-02' of github.com:unity-sds/unity-data-…
wphyojpl Oct 2, 2023
bb16dad
fix: protected-branch error
wphyojpl Oct 2, 2023
3ad72f6
Merge branch 'develop-2023-10-02' of github.com:unity-sds/unity-data-…
wphyojpl Oct 2, 2023
8fb130b
fix: wrong version
wphyojpl Oct 2, 2023
a0357af
fix: using pat token + shell script
wphyojpl Oct 2, 2023
88da687
chore: from develop
wphyojpl Oct 2, 2023
0a5246c
Merge branch 'develop-2023-10-02' of github.com:unity-sds/unity-data-…
wphyojpl Oct 2, 2023
8962f4e
fix: checking ENV
wphyojpl Oct 2, 2023
10c72a0
fix: revert some changes
wphyojpl Oct 2, 2023
c751179
chore: merge from develop
wphyojpl Oct 2, 2023
478a633
Merge branch 'develop-2023-10-02' of github.com:unity-sds/unity-data-…
wphyojpl Oct 2, 2023
a15f005
fix: still debugging
wphyojpl Oct 2, 2023
43a6c3d
Merge branch 'develop-2023-10-02' of github.com:unity-sds/unity-data-…
wphyojpl Oct 2, 2023
ffea60b
chore: dummy commit
wphyojpl Oct 2, 2023
38376ce
chore: update version + change log
wphyojpl Oct 2, 2023
41283ac
chore: update version + change log
wphyojpl Oct 2, 2023
6c42be2
chore: update version + change log
wphyojpl Oct 2, 2023
e8746b6
chore: update version + change log
wphyojpl Oct 2, 2023
422ab2b
chore: update version + change log
wphyojpl Oct 2, 2023
bfce403
chore: merge from develop
wphyojpl Oct 2, 2023
b14ac10
Merge branch 'develop-2023-10-02' into github-action-write-protected-…
wphyojpl Oct 2, 2023
9e5aa5b
fix: adding GH_token
wphyojpl Oct 2, 2023
f3c2e82
fix; displaying env for debug
wphyojpl Oct 3, 2023
bcad524
fix: adding log statements
wphyojpl Oct 3, 2023
24e950b
Merge branch 'develop-2023-10-02' into github-action-write-protected-…
wphyojpl Oct 3, 2023
1453511
fix: not allowing auto merge
wphyojpl Oct 3, 2023
a574d05
chore: merge from remote
wphyojpl Oct 3, 2023
b0c4a88
Merge branch 'develop-2023-10-02' of github.com:unity-sds/unity-data-…
wphyojpl Oct 3, 2023
7400fab
fix: dummy commit
wphyojpl Oct 3, 2023
5311c50
chore: merge from remote
wphyojpl Oct 3, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ Please visit our [developer guide](https://unity-sds.gitbook.io/docs/developer-d

### Run Instructions

Please visit our [developer guide](https://unity-sds.gitbook.io/docs/developer-docs/data/docs/developers-guide) for run instructions..
Please visit our [developer guide](https://unity-sds.gitbook.io/docs/developer-docs/data/docs/developers-guide) for run instructions.

<!-- ☝️ Replace with a numbered list of your run instructions, including expected results ☝️ -->

Expand Down
9 changes: 5 additions & 4 deletions ci.cd/update_version_commit.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ result=`gh pr create --base "${current_branch}" --body "NA" --head "${temp_branc
echo "PR result $result"
pr_number=`echo $result | grep -oE '[0-9]+$'`
echo "PR number ${pr_number}"
# don't allow auto merge to avoid bad actors using it to merge other code
#gh pr review $pr_number --approve
echo "merging PR"
gh pr merge $pr_number --squash --admin
echo "deleting branch"
git push origin --delete ${temp_branch}
#echo "merging PR"
#gh pr merge $pr_number --squash --admin
#echo "deleting branch"
#git push origin --delete ${temp_branch}