JupyterHub Integration into Unity Marketplace: Refactor IAC code for marketplace deployments

[galenatjpl]

After understanding and testing what exists (#489), you should now make changes that enable a seamless Unity Marketplace integration.

In the context of a Unity Marketplace deployment, the Management Console (MC) will execute the terraform code that the marketplace JSON points to (in this case, it will be under: https://github.com/unity-sds/unity-ads-deployment/tree/main/dev_env) . When running terraform apply, the MC will inject some variables automatically into the terraform, such as project and venue (among others). The ADS deployment IAC should be refactored to ensure that it leverages these variables to correctly namespace resources to the project/venue under which it is being deployed.

See: https://unity-sds.gitbook.io/docs/developer-docs/common-services/docs/users-guide/deployment/unity-marketplace
for more details about what variables are expected and get injected.

NOTE: this ticket is NOT actually getting the deployment into the marketplace, but just getting it ready for marketplace integration.

For example, there should be entries in a variables.tf (or similar):

And resources names/IDs should be dynamically leveraging these values. For example:

You should hopefully make changes to the ADS terraform in such a way that it still supports manual deployments outside of the MC, as well as deployments in the MC. For this you may need to slightly modify the deployment instructions and/or rely on a tfvars file.

Acceptance Criteria:

• The terraform is refactored to support MC-injected variables
• The terraform is still deployable/runnable with and without the MC/Marketplace
• Any necessary procedure documentation is updated.

[galenatjpl]

@pymonger I think this ticket is already completed, yes?