Skip to content

Resolved destination path bug #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

Resolved destination path bug #32

merged 1 commit into from
Apr 15, 2025

Conversation

grallewellyn
Copy link
Contributor

Added back in adding the destination directory to the state directory path
Before, this was a bug that would put .unity_app_gen into the current directory which would be confusing if the user had multiple algorithms they were trying to package in the same directory

Tested that all these use cases work:

build_ogc_app init https://github.com/unity-sds/unity-example-application.git unity-example-application
(.unity_app_gen in unity-example-application directory)

build_ogc_app init https://github.com/unity-sds/unity-example-application.git build
(.unity_app_gen in build directory)

git clone https://github.com/unity-sds/unity-example-application.git
cd unity-example-application
build_ogc_app init .
(.unity_app_gen in unity-example-application directory)

Note that in the cases where destination_directory was initially passed, destination_directory will be None for the rest of the build commands but that is okay because the user should be running the build docker command, etc. from the destination directory like the documentation says

@grallewellyn grallewellyn requested a review from mcduffie April 15, 2025 20:39
@mcduffie mcduffie merged commit a62d099 into main Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants