Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#162 Units with higher powers in denominator cannot be formatted with UCUM formatter #165

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

mattdehring
Copy link
Contributor

@mattdehring mattdehring commented May 5, 2020

This change is Reviewable

Copy link
Contributor

@frothga frothga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in UCUMFormat.java works for me. This is actually a pretty crucial bug. Please accept the request.

@keilw
Copy link
Member

keilw commented May 28, 2020

Do they depend on each other? Note, that #167 requires a Java 9 compliant clone of UCUMFormat, so whatever is applied in the default codebase also has to work there.

@frothga
Copy link
Contributor

frothga commented May 28, 2020

They don't depend on each other. IE: you don't need the static import change in order for the fix in UCUMFormat to work. And that fix in UCUMFormat is rather crucial. If you'd like a pull request for just that, I can put one in.

@keilw
Copy link
Member

keilw commented May 28, 2020

I check whether or not it's possible to create a 2.0.2 service release of Unit Systems based on the existing SI 2.0.1 release, there are too many planned features for 2.1 to do this very quickly, but the Jigsaw compliance of UCUMFormat must be guaranteed first, so both the Java 8 and Java9+ version must work.

@keilw keilw merged commit d247025 into unitsofmeasurement:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants